bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
12 Sep 2023

Summary of Changes

add missing translation PLG_SYSTEM_WEBAUTHN_ERR_NOT_DELETED for js function Joomla.Text._()

used here

Joomla.Text._('PLG_SYSTEM_WEBAUTHN_ERR_NOT_DELETED'),

Testing Instructions

add return call to onAjaxWebauthnDelete
image

Actual result BEFORE applying this Pull Request

error message not translated
image

Expected result AFTER applying this Pull Request

error message translated
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 12 Sep 2023
Category Front End Plugins
avatar heelc29 heelc29 - open - 12 Sep 2023
avatar heelc29 heelc29 - change - 12 Sep 2023
Status New Pending
avatar ceford ceford - test_item - 22 Sep 2023 - Tested successfully
avatar ceford
ceford - comment - 22 Sep 2023

I have tested this item ✅ successfully on d3bbd25

Tricky to test - but I do see the untranslated string without the patch and the translated string with the patch. However, without without the patch when I click the button on my Key I get this message above the Authenticator name bar:

 Deprecated: Brick\Math\BigInteger implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /Users/ceford/Sites/joomla-cms4/libraries/vendor/brick/math/src/BigInteger.php on line 22

I guess that is a separate issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41723.

avatar obuisard obuisard - change - 24 Sep 2023
Labels Added: bug PR-4.4-dev
avatar obuisard obuisard - change - 24 Sep 2023
Title
[4.3] WebauthnField missing translation
[4.4] WebauthnField missing translation
avatar obuisard obuisard - edited - 24 Sep 2023
avatar obuisard obuisard - change - 24 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-24 15:30:01
Closed_By obuisard
avatar obuisard obuisard - close - 24 Sep 2023
avatar obuisard obuisard - merge - 24 Sep 2023
avatar obuisard
obuisard - comment - 24 Sep 2023

Thank you @heelc29 for the PR.

Add a Comment

Login with GitHub to post a comment