[#41690] - [5.0] Work around a successful upgrade with silent errors
- Fixed in Code Base
- 13 Sep 2023
- Medium
- Build: 5.0-dev
- # 41690
- Diff
- Fedik:upd-fail-fix2
User tests: Successful: Unsuccessful:
Summary of Changes
This is the same as
But for 5.0 branch.
I think upmerge will be complicated, so I have re-apply changes.
Testing Instructions
If that #41367 will be tested, then this one also should be good.
Note: The patch #41367 should be applied on 4.x version, before test.
Test normal
Try run update from 4.4 => 5.0
The update should work as usual.
Test with error
Simulate an error, add an exception throw new Exception('Test error'); somehwere here
joomla-cms/administrator/components/com_admin/script.php
Lines 2557 to 2565 in 7eff1b7
And do update.
Actual: The update finished with Success message. And nothing in logs.
Expected: The update finished with error message. The error is logged.
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_joomlaupdate Language & Strings Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Language Change
PR-5.0-dev
|
||
| Labels |
Added:
bug
|
||
can I have some tests here please?
can I have some tests here please?
@HLeithner Until when?
@HLeithner the other one PR for 4.3 is tested #41367, and this one is a copy,
Merge this one, and it will be tested all the way untill release ?
since the other pr is only a copy upmerge would make more sense...
since the other pr is only a copy upmerge would make more sense...
@HLeithner That would be not easy because there have been made many changes in script.php for updates. Methods have been removed in 5.0-dev, and new methods have been added.
can you resolve the merge conflict please
I will fix it,
@HLeithner Did you added log for COM_JOOMLAUPDATE_UPDATE_LOG_UNINSTALL_EXTENSIONS?
It missing a real text string
Yes I added it and hope you fix it ;-)
| Category | Administration com_admin com_joomlaupdate Language & Strings Libraries | ⇒ | Administration com_admin com_joomlaupdate Language & Strings |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-13 14:48:57 |
| Closed_By | ⇒ | HLeithner |
thanks
@Fedik I've allowed myself to trigger a branch update so I have the update package created by Drone consistent with current 5.0-dev. I will then create modified packages for testing like I did for the other 4.3-dev PR #41367 . I hope I can do it with less tests here than for the other one.