[#41676] - [5.2] Smart Search: Use UTF8-aware functions when indexing
- Pending
- Medium
- Build: 5.0-dev
- # 41676
- Diff
- Hackwar:5.0-finder-utf8parsing
User tests: Successful: Unsuccessful:
Pull Request for Issue #40543. Re-work of #41502
Summary of Changes
The parsing and processing code so far used non-utf8-safe functions like substr(), strrpos(), etc. This resulted in broken parsing in some cases and thus the behavior of #40543. The reworked PR now has the stripos() issue fixed.
Testing Instructions
Please copy the text from #40543 into an article and replace the p-tags between the paragraphs with br-tags instead. Save the content. If you look at the entry in #__finder_links for that content item, you will see the content in the description column and some words have been pushed together, removing the space between them.
Actual result BEFORE applying this Pull Request
No space between some words.
Expected result AFTER applying this Pull Request
All words are seperated with one space.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Feature
PR-5.0-dev
|
||
Why is this marked as a feature? This should have gone into 5.0, maybe even 4.4...
some changes makes no sense anyway, if you search for a space and only use it with non utf8 functions it makes no sense to have the overhead of utf8 functions
I went through the PR again and the utf8 functions are actually necessary.
please explain why
| Title |
|
||||||
I have tested this item ? unsuccessfully on 25cfdab
cannot reproduce the initial fault (there are always the right spaces between the words)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41676.
I have tested this item ? unsuccessfully on 25cfdab
Spaces are all there.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41676.
bembelimen
- | Title |
|
||||||
| Labels |
Added:
PBF
bug
PR-5.2-dev
Removed: Feature PR-5.0-dev |
||
@HLeithner you were right, that a few of the functions were unnecessary. I removed some of the changes. Would be nice to get this going now.
This pull request has been automatically rebased to 5.1-dev.