Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41670] - 5.0 Prefer is_object() vs gettype()

PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
8 Sep 2023

Summary of Changes

Use is_object() instead of gettype() comparison to simplify the logic.

Testing Instructions

Apply patch.

Actual result BEFORE applying this Pull Request

See usual code.

Expected result AFTER applying this Pull Request

See nice code.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

4f55a75 8 Sep 2023 avatar fix
avatar joomla-cms-bot joomla-cms-bot - change - 8 Sep 2023
Category ⇒ Administration Libraries
avatar Denitz Denitz - open - 8 Sep 2023
avatar Denitz Denitz - change - 8 Sep 2023
Status New ⇒ Pending
avatar Denitz Denitz - change - 8 Sep 2023
Title
…
fix
5.0 Prefer is_object() vs gettype()
avatar Denitz Denitz - edited - 8 Sep 2023
avatar HLeithner HLeithner - close - 12 Sep 2023
avatar HLeithner HLeithner - merge - 12 Sep 2023
avatar HLeithner HLeithner - change - 12 Sep 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-09-12 14:52:51
Closed_By ⇒ HLeithner
Labels Added: PR-5.0-dev
avatar HLeithner
HLeithner - comment - 12 Sep 2023

thanks

avatar HLeithner
HLeithner - comment - 12 Sep 2023

merged by code review, is_object seems to be much faster then gettype

Add a Comment

Login with GitHub to post a comment