Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
8 Sep 2023

Summary of Changes

Use self instead of self class name.

Testing Instructions

Apply patch.

Actual result BEFORE applying this Pull Request

Complex code.

Expected result AFTER applying this Pull Request

Nice code.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

b9877c2 8 Sep 2023 avatar fix
avatar joomla-cms-bot joomla-cms-bot - change - 8 Sep 2023
Category Libraries Modules Front End Plugins
avatar Denitz Denitz - open - 8 Sep 2023
avatar Denitz Denitz - change - 8 Sep 2023
Status New Pending
avatar HLeithner
HLeithner - comment - 12 Sep 2023

This change is not so easy because it really depends what you want, using self would mean the defined object but the question is if static would be better in some cases if the class gets extended. So that pr is not a no brainier and needs some time to evaluate each replacement case

avatar HLeithner HLeithner - change - 12 Sep 2023
Title
5.0 Self-class referencing
[5.0] Self-class referencing
avatar HLeithner HLeithner - edited - 12 Sep 2023
avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar Denitz Denitz - change - 3 Oct 2023
Title
[5.0] Self-class referencing
[5.1] Self-class referencing
avatar Denitz Denitz - edited - 3 Oct 2023
avatar HLeithner
HLeithner - comment - 24 Apr 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
[5.1] Self-class referencing
[5.2] Self-class referencing
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar HLeithner
HLeithner - comment - 2 Sep 2024

This pull request has been automatically rebased to 5.3-dev.

avatar HLeithner HLeithner - change - 2 Sep 2024
Title
[5.2] Self-class referencing
[5.3] Self-class referencing
avatar HLeithner HLeithner - edited - 2 Sep 2024

Add a Comment

Login with GitHub to post a comment