[#41662] - [5.2] parent keyword misused
- Fixed in Code Base
- 29 Jul 2024
- Medium
- Build: 5.0-dev
- # 41662
- Diff
- Denitz:5.0_parent_keyword_misused
User tests: Successful: Unsuccessful:
Summary of Changes
Use $this-> instead of parent:: in the non-parent methods.
Testing Instructions
Apply patch
Actual result BEFORE applying this Pull Request
See IDE warnings, plus inability to extend from certain classes with calling own methods.
Expected result AFTER applying this Pull Request
No IDE warnings, composition is better.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_associations Front End com_contact com_content |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
This pull request has been automatically rebased to 5.1-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
Looking at the code, all looks correct and other than #41661 there is nothing wrong here. Could @rdeutz and @HLeithner review/test this? Then I could merge it.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
RTC
PR-5.2-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-29 13:56:55 |
| Closed_By | ⇒ | Hackwar |
As #41661 this must be evaluated per case what we want.