Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41655] - [5.0] Simplify boolean logic

PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
7 Sep 2023

Summary of Changes

Simplify boolean logic.

Testing Instructions

Apply patch

Actual result BEFORE applying this Pull Request

Bad code

Expected result AFTER applying this Pull Request

Nice code

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

61be6b4 7 Sep 2023 avatar Denitz fix
avatar joomla-cms-bot joomla-cms-bot - change - 7 Sep 2023
Category ⇒ Administration com_config com_finder com_installer com_menus Front End com_users Installation Libraries Plugins
avatar Denitz Denitz - open - 7 Sep 2023
avatar Denitz Denitz - change - 7 Sep 2023
Status New ⇒ Pending
avatar HLeithner HLeithner - change - 12 Sep 2023
Title
…
5.0 Simplify boolean logic
[5.0] Simplify boolean logic
avatar HLeithner HLeithner - edited - 12 Sep 2023
avatar Denitz Denitz - change - 13 Sep 2023
Labels Added: PR-5.0-dev
avatar Quy Quy - test_item - 16 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 16 Sep 2023

I have tested this item ✅ successfully on 0f0087e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41655.

avatar HLeithner
HLeithner - comment - 18 Sep 2023

@Quy did you tested all cases, i have some concerns about switch text detection from !== 'false' to === 'true' because that's actually a different use case, not use if it has the same outcome

avatar Quy
Quy - comment - 18 Sep 2023

I assume you are referring to this one:

'useEmojis' => $this->params->get('useEmojis') === 'true',

Yes, I toggled its setting and it worked accordingly.

avatar HLeithner HLeithner - change - 19 Sep 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-09-19 06:34:40
Closed_By ⇒ HLeithner
avatar HLeithner HLeithner - close - 19 Sep 2023
avatar HLeithner HLeithner - merge - 19 Sep 2023
avatar HLeithner
HLeithner - comment - 19 Sep 2023

Merging this for beta2, thanks

Add a Comment

Login with GitHub to post a comment