User tests: Successful: Unsuccessful:
Here is a pull request as described in my previous issue #4152.
I have tested it with and without port definition and both works in my configuration.
Status | Pending | ⇒ | New |
Labels |
Added:
?
|
Another solution, now the port was checked in the constructor (and saved in $options
/ $this->options
).
But the isset($options['port'])
directive has no effect, it was not passed from configuration.php.
Category | ⇒ | Postgresql |
I have searched for allowed characters for the hostname (never trust user input) and I've found this: https://tools.ietf.org/html/rfc3986#section-3.2.2 . My solution is not IPv6 compatible.
Status | New | ⇒ | Pending |
Ported your solution for postgresql with two exceptions.
Labels |
Added:
?
|
Labels |
Removed:
?
|
Please update your PR to latest staging and fix the merge conflicts.
Hello @Joe136
Thank you for your contribution.
The last comment here was on 3rd February. Can you please respond to the feedback given?
If no reply is received within 4 weeks we will close this issue.
Thanks for understanding!
Status | Pending | ⇒ | Information Required |
Status | Information Required | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-12-17 11:12:10 |
Closed_By | ⇒ | brianteeman |
Closed due to lack of response for further information - it can always be reopened if that is provided
Instead of making them local variables, I'd suggest writing the split data back to
$this->options
should they need to be reused for anything later (which is the same as what the MySQLi driver does).