? Failure

User tests: Successful: Unsuccessful:

avatar Joe136
Joe136
23 Aug 2014

Here is a pull request as described in my previous issue #4152.

I have tested it with and without port definition and both works in my configuration.

avatar Joe136 Joe136 - open - 23 Aug 2014
avatar jissues-bot jissues-bot - change - 23 Aug 2014
Status Pending New
Labels Added: ?
avatar mbabker
mbabker - comment - 23 Aug 2014

Instead of making them local variables, I'd suggest writing the split data back to $this->options should they need to be reused for anything later (which is the same as what the MySQLi driver does).

avatar Joe136 Joe136 - reference | - 23 Aug 14
avatar Joe136 Joe136 - reference | - 23 Aug 14
avatar Joe136
Joe136 - comment - 23 Aug 2014

Another solution, now the port was checked in the constructor (and saved in $options / $this->options).
But the isset($options['port']) directive has no effect, it was not passed from configuration.php.

avatar brianteeman brianteeman - change - 25 Aug 2014
Category Postgresql
avatar Joe136
Joe136 - comment - 27 Aug 2014

I have searched for allowed characters for the hostname (never trust user input) and I've found this: https://tools.ietf.org/html/rfc3986#section-3.2.2 . My solution is not IPv6 compatible.

avatar brianteeman brianteeman - change - 27 Aug 2014
Status New Pending
avatar Joe136 Joe136 - reference | - 4 Sep 14
avatar Joe136 Joe136 - reference | - 4 Sep 14
avatar Joe136
Joe136 - comment - 4 Sep 2014

Ported your solution for postgresql with two exceptions.

  1. different way for unix sockets: I have tested it and it works for me. But it is (currently) limited to special characters: (/[a-zA-Z0-9.-_]*)+ . Additionally something like /var/../var/pg is posible (maybe bad).
  2. IPv6 doesn't need the [] characters. It works for localhost ::1 but not for a real address (eth0 IPv6) (and not with psql; don't know why).
avatar Joe136 Joe136 - reference | - 4 Sep 14
avatar Joe136 Joe136 - reference | - 4 Sep 14
avatar nicksavov nicksavov - change - 16 Oct 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 1 Jan 2015
Labels Removed: ?
avatar Hackwar
Hackwar - comment - 3 Feb 2015

Please update your PR to latest staging and fix the merge conflicts.

avatar roland-d
roland-d - comment - 8 Nov 2015

Hello @Joe136

Thank you for your contribution.

The last comment here was on 3rd February. Can you please respond to the feedback given?
If no reply is received within 4 weeks we will close this issue.

Thanks for understanding!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4165.

avatar roland-d roland-d - change - 8 Nov 2015
Status Pending Information Required
avatar brianteeman brianteeman - change - 17 Dec 2015
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2015-12-17 11:12:10
Closed_By brianteeman
avatar brianteeman brianteeman - close - 17 Dec 2015
avatar brianteeman brianteeman - close - 17 Dec 2015
avatar brianteeman
brianteeman - comment - 17 Dec 2015

Closed due to lack of response for further information - it can always be reopened if that is provided


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4165.

Add a Comment

Login with GitHub to post a comment