PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
5 Sep 2023

Simple PR to change the title of the three newly created tasks to real words (if possible).

As these are not translated strings it makes it easier for machine translators when real words are used

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 5 Sep 2023
Category Administration com_admin SQL Installation Postgresql
avatar brianteeman brianteeman - open - 5 Sep 2023
avatar brianteeman brianteeman - change - 5 Sep 2023
Status New Pending
avatar HLeithner
HLeithner - comment - 5 Sep 2023

That will not migration beta1 installations right?

avatar richard67
richard67 - comment - 5 Sep 2023

@brianteeman Shouldn't these be changed, too, if we go that way?

The 3 tasks which you have found are created with the deletion of the old, obsolete system plugin.

The 2 mentioned by me are created when the old system plugin continues to exist and only some of their parameters are moved to the new task, that's why those 2 are in the postflight.

@HLeithner Should we migrate the Beta 1 task titles with Beta 2? I'm not sure if it's worth the effort, as the titles are used only for title display and nothing else, i.e. not in any code for identifying a task. At least I don't remember having seen anything like that.

On the long run I think task titles should be translatable. No idea why that's not the case.

avatar brianteeman brianteeman - change - 5 Sep 2023
Labels Added: PR-5.0-dev
avatar alikon
alikon - comment - 5 Sep 2023

as long as this don't cost to us any extra effort from moving beta to beta, or whatever
fine for me

avatar richard67 richard67 - test_item - 5 Sep 2023 - Tested successfully
avatar richard67
richard67 - comment - 5 Sep 2023

I have tested this item ✅ successfully on 9f44be7

I don't think it needs an update SQL script to update the titles from beta 1 to beta 2.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41603.

avatar alikon alikon - test_item - 5 Sep 2023 - Tested successfully
avatar alikon
alikon - comment - 5 Sep 2023

I have tested this item ✅ successfully on 9f44be7

cr


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41603.

avatar alikon alikon - change - 5 Sep 2023
Status Pending Ready to Commit
avatar alikon
alikon - comment - 5 Sep 2023

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41603.

avatar HLeithner
HLeithner - comment - 5 Sep 2023

yes we should update from beta1 to beta2 the titles.

avatar richard67
richard67 - comment - 5 Sep 2023

yes we should update from beta1 to beta2 the titles.

@brianteeman Could you do that with a new update SQL script for each db type? Here my suggestion for MySQL. For PostgreSQL it just needs to change the names quotes.

UPDATE `#__scheduler_tasks` SET `title` = 'Delete Action Logs' WHERE `type` = 'delete.actionlogs' AND `title` = 'DeleteActionLogs';
UPDATE `#__scheduler_tasks` SET `title` = 'Privacy Consent' WHERE `type` = 'privacy.consent' AND `title` = 'PrivacyConsent';
UPDATE `#__scheduler_tasks` SET `title` = 'Rotate Logs' WHERE `type` = 'rotation.logs' AND `title` = 'RotateLogs';
UPDATE `#__scheduler_tasks` SET `title` = 'Session GC' WHERE `type` = 'session.gc' AND `title` = 'SessionGC';
UPDATE `#__scheduler_tasks` SET `title` = 'Update Notification' WHERE `type` = 'update.notification' AND `title` = 'UpdateNotification';

The type should be in the where condition to not accidentally update an unrelated task with that title, and the title is in the where condition in order not to update the title for that type when the user has already changed it to something else.

avatar brianteeman
brianteeman - comment - 5 Sep 2023

will do that in the morning

avatar brianteeman brianteeman - change - 6 Sep 2023
Labels Added: ?
avatar brianteeman
brianteeman - comment - 6 Sep 2023

sql updates added

avatar richard67 richard67 - change - 12 Sep 2023
Status Ready to Commit Pending
avatar richard67
richard67 - comment - 12 Sep 2023

Back to pending doe to changes (new update SQL).

@alikon Could you test again? Maybe this time also with updating a 5.0-dev to the update package or custom update URL from Drone. I will do that myself too in a minute or two.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41603.

avatar richard67 richard67 - test_item - 12 Sep 2023 - Tested successfully
avatar richard67
richard67 - comment - 12 Sep 2023

I have tested this item ✅ successfully on 7ca4991


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41603.

avatar HLeithner
HLeithner - comment - 12 Sep 2023

can you please fix the merge conflict then it can be merged.

avatar richard67 richard67 - change - 12 Sep 2023
Labels Removed: ?
avatar richard67
richard67 - comment - 12 Sep 2023

can you please fix the merge conflict then it can be merged.

@HLeithner @brianteeman I've allowed myself to do that.

avatar HLeithner HLeithner - change - 12 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-12 11:28:24
Closed_By HLeithner
avatar HLeithner HLeithner - close - 12 Sep 2023
avatar HLeithner HLeithner - merge - 12 Sep 2023
avatar brianteeman
brianteeman - comment - 12 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment