? bug PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
5 Sep 2023

Pull Request for Issue #41572, #41578 .

Summary of Changes

The patch renders toolbar in tmpl/modal.php layout, instead of in global component.php

Testing Instructions

Edit menu for Single Article, use modal select, create, edit for article.
Aslo try menu for Category, Contact, Newsfeed.

Edit an article, select an image in Media. Repeat it in front-end.

Also try to add a module to dashboard.

Actual result BEFORE applying this Pull Request

There a doubled toolbars.

Expected result AFTER applying this Pull Request

No doubled toolbar.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

Reference:

avatar joomla-cms-bot joomla-cms-bot - change - 5 Sep 2023
Category Administration com_content com_media Templates (admin)
avatar Fedik Fedik - open - 5 Sep 2023
avatar Fedik Fedik - change - 5 Sep 2023
Status New Pending
avatar Fedik Fedik - change - 5 Sep 2023
Labels Added: PR-5.0-dev
avatar Fedik Fedik - change - 5 Sep 2023
Labels Added: bug
avatar richard67 richard67 - test_item - 5 Sep 2023 - Tested successfully
avatar richard67
richard67 - comment - 5 Sep 2023

I have tested this item ✅ successfully on 2a6f1be


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41600.

avatar Quy
Quy - comment - 6 Sep 2023

For Create Article, buttons should be in the footer.

41600-header

like the following:

41600-footer

avatar Fedik
Fedik - comment - 6 Sep 2023

For Create Article, buttons should be in the footer.

Nope. It is new, part of

Other modals currently still use Bootstrap, and should be transformed in future.

avatar Quy Quy - test_item - 6 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 6 Sep 2023

I have tested this item ✅ successfully on 2a6f1be


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41600.

avatar Quy Quy - change - 6 Sep 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 6 Sep 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41600.

avatar Quy Quy - change - 6 Sep 2023
Labels Added: ?
avatar HLeithner HLeithner - change - 12 Sep 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-12 18:12:00
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 12 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment