User tests: Successful: Unsuccessful:
Pull Request for #40553 (comment) .
The new task scheduler plugin "plg_task_privacyconsent" added with PR #40553 queries the database to check for privacy consents for which a reminder should be sent or which are expired.
It uses an own language string key PLG_TASK_PRIVACYCONSENT_SUBJECT
for the subject column of the #__privacy_consents
table in the WHERE condition.
But the privacy consent system plugin which is still handling the non-cyclic functionality inserts the records with language string key PLG_SYSTEM_PRIVACYCONSENT_SUBJECT
.
See also #40553 (comment) .
This is wrong.
The scheduler task should query for records with the PLG_SYSTEM_PRIVACYCONSENT_SUBJECT
.
The language strings are not translated, only they keys are used, and string PLG_TASK_PRIVACYCONSENT_SUBJECT
is not used anywhere else.
Code review.
Wrong language string key used in query.
Right language string key used, and obsolete wrong key removed from the language file of the new scheduler task plugin.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Category | ⇒ | Administration Language & Strings Front End Plugins |
Status | New | ⇒ | Pending |
Title |
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-05 08:46:27 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
Language Change
PR-5.0-dev
?
|
thanks