Language Change PR-5.0-dev ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
5 Sep 2023

Pull Request for #40553 (comment) .

Summary of Changes

The new task scheduler plugin "plg_task_privacyconsent" added with PR #40553 queries the database to check for privacy consents for which a reminder should be sent or which are expired.

It uses an own language string key PLG_TASK_PRIVACYCONSENT_SUBJECT for the subject column of the #__privacy_consents table in the WHERE condition.

But the privacy consent system plugin which is still handling the non-cyclic functionality inserts the records with language string key PLG_SYSTEM_PRIVACYCONSENT_SUBJECT.

See also #40553 (comment) .

This is wrong.

The scheduler task should query for records with the PLG_SYSTEM_PRIVACYCONSENT_SUBJECT.

The language strings are not translated, only they keys are used, and string PLG_TASK_PRIVACYCONSENT_SUBJECT is not used anywhere else.

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

Wrong language string key used in query.

Expected result AFTER applying this Pull Request

Right language string key used, and obsolete wrong key removed from the language file of the new scheduler task plugin.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 5 Sep 2023
Category Administration Language & Strings Front End Plugins
avatar richard67 richard67 - open - 5 Sep 2023
avatar richard67 richard67 - change - 5 Sep 2023
Status New Pending
avatar richard67 richard67 - change - 5 Sep 2023
Title
5.0 dev fix privacy consent task plugin
[5.0] Fix wrong language string constant used in database query of privacyconsent task scheduler plugin
avatar richard67 richard67 - edited - 5 Sep 2023
avatar HLeithner HLeithner - close - 5 Sep 2023
avatar HLeithner HLeithner - merge - 5 Sep 2023
avatar HLeithner HLeithner - change - 5 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-05 08:46:27
Closed_By HLeithner
Labels Added: Language Change PR-5.0-dev ?
avatar HLeithner
HLeithner - comment - 5 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment