PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
4 Sep 2023

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the list of files to be deleted on update in file "administrator/components/com_admin/script.php" in preparation for the upcoming 5.0.0-beta1 release.

Currently there is only one file added, which comes from a dependency update in the 4.0-dev branch and never has existed in 5.0-dev.

Therefore the file is not added to the end of the list with a new section "// From 5.0.0-alpha4 to 5.0.0-beta1" but to the first section "// From 4.4 to 5.0". The parent folder of that file is already in the list of folders to be deleted and is in the same section.

We do it in the same way with other files specific to 4.4, e.g. all the 4.x update SQL scripts are in section "// From 4.4 to 5.0".

Testing Instructions

Code review, or compare a "Joomla_5.0.0-beta1-dev-Development-Full_Package_2023-09-04" with a "Joomla_4.4.0-alpha5-dev-Development-Full_Package" zip package, both built on the current branches 5.0-dev and 4.4-dev with command php ./build/build.php --remote=HEAD --exclude-gzip --exclude-bzip2.

Actual result BEFORE applying this Pull Request

File "libraries/vendor/symfony/polyfill-php81/Resources/stubs/CURLStringFile.php" will not be deleted on update, but the parent folder will, and so the file will be deleted, too.

Expected result AFTER applying this Pull Request

File "libraries/vendor/symfony/polyfill-php81/Resources/stubs/CURLStringFile.php" will be deleted on update, and it's in the list in script.php so people know that, like we have it for all other files where the parent folder is deleted.

This might change in future, but for now we should stick with the existing practice.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2023
Category Administration com_admin
avatar richard67 richard67 - open - 4 Sep 2023
avatar richard67 richard67 - change - 4 Sep 2023
Status New Pending
avatar HLeithner HLeithner - change - 4 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-04 14:52:49
Closed_By HLeithner
Labels Added: PR-5.0-dev
avatar HLeithner HLeithner - close - 4 Sep 2023
avatar HLeithner HLeithner - merge - 4 Sep 2023

Add a Comment

Login with GitHub to post a comment