No Code Attached Yet bug
avatar heelc29
heelc29
3 Sep 2023

Steps to reproduce the issue

compare 4.4 or 5.0-alpha 4 with latest 5.0-dev (contains #41409) @wilsonge

Expected result

image
image
image
image

Actual result

  • background of table (also language table)
    image

  • background list
    image

  • background arrow (also some more of these kind of fields)
    image

  • background and form of toolbar buttons
    image

avatar heelc29 heelc29 - open - 3 Sep 2023
avatar joomla-cms-bot joomla-cms-bot - change - 3 Sep 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 3 Sep 2023
avatar heelc29 heelc29 - change - 3 Sep 2023
Title
Display issues after Dark Mode support
[5.0] Display issues after Dark Mode support
avatar heelc29 heelc29 - edited - 3 Sep 2023
avatar brianteeman
brianteeman - comment - 3 Sep 2023

confirmed

avatar brianteeman brianteeman - change - 3 Sep 2023
Labels Added: bug
avatar brianteeman brianteeman - labeled - 3 Sep 2023
avatar wilsonge
wilsonge - comment - 5 Sep 2023

Thankyou. I’m aware of this and the stuff @Quy mentioned in the original post. I’m currently on holiday but will address this as soon as I can when I’m back (on Friday).

avatar wilsonge
wilsonge - comment - 5 Sep 2023

https://github.com/joomla/joomla-cms/blob/4.3-dev/build/media_source/templates/administrator/atum/scss/_variables.scss#L49

In the meantime if anyone else is interested in solving this specific one before I get back. In most these places we’re using this action variable which is supposed to be blue. So we need to figure out in J4 why it was white in most cases!

avatar brianteeman
brianteeman - comment - 5 Sep 2023

there is a variable that is not defined causing issues

var(--bg-color);

looking at the code before the pr this was always
$white;

avatar wilsonge
wilsonge - comment - 6 Sep 2023

#41615

First PR (fixes the 4th screenshot here)

avatar wilsonge
wilsonge - comment - 6 Sep 2023

#41626

Second PR fixes the 3rd screenshot for the form selects

avatar wilsonge
wilsonge - comment - 6 Sep 2023

#41627

Third PR fixes the 1st screenshot for installation tables

avatar richard67
richard67 - comment - 7 Sep 2023

@wilsonge Do the 3 PRs #41625 , #41626 and #41627 together fix this issue? or is there something remaining?

avatar wilsonge
wilsonge - comment - 7 Sep 2023

Background of menu item lists (screenshot 2) still left to fix

avatar wilsonge wilsonge - change - 17 Sep 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-09-17 02:52:44
Closed_By wilsonge
avatar wilsonge wilsonge - close - 17 Sep 2023
avatar wilsonge
wilsonge - comment - 17 Sep 2023

Final fix here #41772

Add a Comment

Login with GitHub to post a comment