PR-4.3-dev PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
2 Sep 2023

Summary of Changes

Assuming that CacheController proxifies all missed methods to Cache via __call, for IDE code completion can mix Cache methods

Testing Instructions

Apply patch

Actual result BEFORE applying this Pull Request

See tons of "Method not found" warnings in IDE, i.e. in ModuleHelper::moduleCache()

Expected result AFTER applying this Pull Request

$cache->setCaching() is identified by IDE if $cache is mentioned as i.e. /** @var CallbackController $cache */

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 2 Sep 2023
Category Libraries
avatar Denitz Denitz - open - 2 Sep 2023
avatar Denitz Denitz - change - 2 Sep 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Sep 2023
Category Libraries Unit Tests Repository Administration com_admin SQL
avatar Denitz Denitz - change - 23 Sep 2023
Labels Added: PR-4.3-dev
avatar joomla-cms-bot joomla-cms-bot - change - 23 Sep 2023
Category Unit Tests Repository Administration com_admin SQL Libraries
avatar Denitz Denitz - change - 23 Sep 2023
Title
CacheController @mixin Cache
[5.0] CacheController @mixin Cache
avatar Denitz Denitz - edited - 23 Sep 2023
avatar HLeithner HLeithner - change - 24 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-24 08:39:52
Closed_By HLeithner
Labels Added: PR-5.0-dev
avatar HLeithner HLeithner - close - 24 Sep 2023
avatar HLeithner HLeithner - merge - 24 Sep 2023
avatar HLeithner
HLeithner - comment - 24 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment