? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
2 Sep 2023

Summary of Changes

PHP 8.2, Creation of dynamic property

Testing Instructions

Use PHP 8.2, see Creation of dynamic property in FileAdapter

Actual result BEFORE applying this Pull Request

Deprecation warning

Expected result AFTER applying this Pull Request

No warning

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 2 Sep 2023
Category Libraries
avatar Denitz Denitz - open - 2 Sep 2023
avatar Denitz Denitz - change - 2 Sep 2023
Status New Pending
avatar Denitz Denitz - change - 3 Sep 2023
The description was changed
avatar Denitz Denitz - edited - 3 Sep 2023
avatar obuisard
obuisard - comment - 13 Sep 2023

Hello, I would leave protected $scriptElement = null; and match the other adapters

avatar Denitz Denitz - change - 13 Sep 2023
Labels Added: PR-4.3-dev
avatar Denitz
Denitz - comment - 13 Sep 2023

@obuisard Done.

avatar obuisard obuisard - test_item - 13 Sep 2023 - Tested successfully
avatar obuisard
obuisard - comment - 13 Sep 2023

I have tested this item ✅ successfully on 7c4a8ea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41554.

avatar Quy Quy - test_item - 13 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 13 Sep 2023

I have tested this item ✅ successfully on 7c4a8ea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41554.

avatar Quy Quy - change - 13 Sep 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 13 Sep 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41554.

avatar obuisard obuisard - change - 18 Sep 2023
Labels Added: ?
avatar obuisard obuisard - close - 18 Sep 2023
avatar obuisard obuisard - merge - 18 Sep 2023
avatar obuisard obuisard - change - 18 Sep 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-18 23:34:32
Closed_By obuisard
avatar obuisard
obuisard - comment - 18 Sep 2023

Thank you @Denitz for the PR.

Add a Comment

Login with GitHub to post a comment