[#41547] - [5.0] Remove the backslash
- Closed
- 2 Sep 2023
- Medium
- Build: 5.0-dev
- # 41547
- Diff
- sandewt:patch-7
User tests: Successful: Unsuccessful:
The backslash is not needed here.
Pull Request for Issue # .
Summary of Changes
See: #40553 (comment)
Testing Instructions
Code review
Actual result BEFORE applying this Pull Request
} catch (\Exception $e) {
Expected result AFTER applying this Pull Request
} catch (Exception $e) {
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
| Status | New | ⇒ | Pending |
This change is not correct - see the maintainers decision here #41427 (comment)
This change is not correct - see the maintainers decision here #41427 (comment)
I see. @sandewt That means this PR here is not right according to that decision, and we should add the backslash in @alikon 's PRs. Sorry for the confusion.
Sorry for the confusion.
It's OK. Developments sometimes go very fast.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-02 13:36:21 |
| Closed_By | ⇒ | sandewt | |
| Labels |
Added:
PR-5.0-dev
?
|
||
Outdated code, maintainers decision.
I have tested this item ✅ successfully on 38a4114
Yep, was my mistake. It doesn't do harm, but as the file is not namespaced we should prefer without backslash, like it is already at other places in that file.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41547.