Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41543] - Text::script should update existing script strings

? bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
1 Sep 2023

Pull Request for Issue #41516 .

Summary of Changes

The HTMLDocument::setHeadData restores scriptOptions correctly, hovewer any further call of Text::script override previously restored strings.

Testing Instructions

Please follow #41516 .
Or add :

Text::script('JYES');
$this->document->addScriptOptions('yes', 'Yes');
$this->document->getWebAssetManager()
    ->addInlineScript('console.log(Joomla.getOptions("yes", "nope") + " " + Joomla.Text._("JYES", "Nope"))', [], ['type' => 'module']);

After this line

joomla-cms/components/com_content/src/View/Article/HtmlView.php

Line 242 in 1e7527b

$this->_prepareDocument();

Enable "Conservative caching"
Open any Article view.
Check browser console.

Actual result BEFORE applying this Pull Request

First request: Yes Yes
All following requests: Yes Nope

Expected result AFTER applying this Pull Request

Every reques there a log Yes Yes

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 1 Sep 2023
Category ⇒ Libraries
avatar Fedik Fedik - open - 1 Sep 2023
avatar Fedik Fedik - change - 1 Sep 2023
Status New ⇒ Pending
avatar Fedik Fedik - change - 1 Sep 2023
The description was changed
avatar Fedik Fedik - edited - 1 Sep 2023
avatar Fedik Fedik - change - 1 Sep 2023
The description was changed
avatar Fedik Fedik - edited - 1 Sep 2023
avatar ceford ceford - test_item - 25 Sep 2023 - Tested successfully
avatar ceford
ceford - comment - 25 Sep 2023

I have tested this item ✅ successfully on 42b0d7a

On this one I did not realise at first that I needed to look in the Console Logs which is not selected by default.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41543.

avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 4.4-dev.

avatar viocassel viocassel - test_item - 14 Nov 2023 - Tested successfully
avatar viocassel
viocassel - comment - 14 Nov 2023

I have tested this item ✅ successfully on 42b0d7a

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41543.

avatar Quy Quy - change - 14 Nov 2023
Status Pending ⇒ Ready to Commit
Labels Added: bug PR-4.4-dev
avatar Quy
Quy - comment - 14 Nov 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41543.

avatar laoneo laoneo - change - 15 Nov 2023
Labels Added: ?
avatar Fedik Fedik - change - 15 Nov 2023
Labels Added: ?
Removed: ?
avatar laoneo laoneo - change - 15 Nov 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-11-15 09:34:59
Closed_By ⇒ laoneo
Labels Added: ?
Removed: ?
avatar laoneo laoneo - close - 15 Nov 2023
avatar laoneo laoneo - merge - 15 Nov 2023
avatar laoneo
laoneo - comment - 15 Nov 2023

Thanks!

Add a Comment

Login with GitHub to post a comment