User tests: Successful: Unsuccessful:
Category | ⇒ | External Library Composer Change NPM Change |
Status | New | ⇒ | Pending |
Labels |
Added:
Composer Dependency Changed
NPM Resource Changed
PR-4.4-dev
|
Category | External Library Composer Change NPM Change | ⇒ | External Library Composer Change NPM Change Front End Plugins |
Not sure why this is not part of the update command @dgrammatiko ?
Thanks, fixed it
Something is wrong here. The vue
package is a hard dependency, but I can't find it as a full package in the package-lock.json.
There are over 7'000 removald un the package lock file in this pr. Not sure if this has something to do with a never npm version since I did it last time.
@brianteeman which npm version did you use?
I'v just did a fresh install of the package from drone and all works. Nothing indicates that there is an error in an asset. Also the system tests are running through, when they do not hit the timeout.
@brianteeman which npm version did you use?
8.19.2
Reverted the last commit
@brianteeman which npm version did you use?
8.19.2
That might be the issue as I'm on 9.6.7.
@dgrammatiko gets the same effect, so we are fine with this pr here as I do mainly the updates
FWIW it's time to push node/npm as 16 that we are currently have as minimum goes EOL in few weeks. It's on my todo list
But I would do it on 5.0 then only.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-04 12:21:34 |
Closed_By | ⇒ | laoneo |
I have tested this item ? unsuccessfully on b12d4eb
This is not correct.
You must do a full npm and composer install when you do these updates as there are files that might get updated by other scripts when dependencies are updated.
For example tinmyce and codemirror where the version number in the plugin is updated
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41538.