Composer Dependency Changed NPM Resource Changed PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
1 Sep 2023

Updates the dependencies including the lift to cypress 13 as there was a vulnerability reported in cypress 12.

image

avatar joomla-cms-bot joomla-cms-bot - change - 1 Sep 2023
Category External Library Composer Change NPM Change
avatar laoneo laoneo - open - 1 Sep 2023
avatar laoneo laoneo - change - 1 Sep 2023
Status New Pending
avatar laoneo laoneo - change - 1 Sep 2023
Labels Added: Composer Dependency Changed NPM Resource Changed PR-4.4-dev
avatar brianteeman brianteeman - test_item - 1 Sep 2023 - Tested unsuccessfully
avatar laoneo laoneo - change - 1 Sep 2023
The description was changed
avatar laoneo laoneo - edited - 1 Sep 2023
avatar brianteeman
brianteeman - comment - 1 Sep 2023

I have tested this item ? unsuccessfully on b12d4eb

This is not correct.
You must do a full npm and composer install when you do these updates as there are files that might get updated by other scripts when dependencies are updated.

For example tinmyce and codemirror where the version number in the plugin is updated


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41538.

avatar joomla-cms-bot joomla-cms-bot - change - 1 Sep 2023
Category External Library Composer Change NPM Change External Library Composer Change NPM Change Front End Plugins
avatar laoneo
laoneo - comment - 1 Sep 2023

Not sure why this is not part of the update command @dgrammatiko ?

avatar dgrammatiko
dgrammatiko - comment - 1 Sep 2023

rpm run update:

"update": "node build/build.js --copy-assets && node build/build.js --build-pages && node build/build.js --compile-js && node build/build.js --compile-css && node build/build.js --compile-bs && set NODE_ENV=PRODUCTION && node build/build.js --com-media",
?

Edit: you need to manually bump the package.json versions and then run the command above IIRC

avatar laoneo
laoneo - comment - 1 Sep 2023

Thanks, fixed it

avatar Hackwar
Hackwar - comment - 1 Sep 2023

Something is wrong here. The vue package is a hard dependency, but I can't find it as a full package in the package-lock.json.

avatar Hackwar
Hackwar - comment - 1 Sep 2023

In any case, since this PR already contains those updates, I'm closing #41451 and #41455.

avatar laoneo
laoneo - comment - 1 Sep 2023

There are over 7'000 removald un the package lock file in this pr. Not sure if this has something to do with a never npm version since I did it last time.

avatar brianteeman
brianteeman - comment - 1 Sep 2023

I tried and built #41545 for comparison

avatar laoneo
laoneo - comment - 4 Sep 2023

@brianteeman which npm version did you use?

avatar laoneo
laoneo - comment - 4 Sep 2023

I'v just did a fresh install of the package from drone and all works. Nothing indicates that there is an error in an asset. Also the system tests are running through, when they do not hit the timeout.

avatar brianteeman
brianteeman - comment - 4 Sep 2023

@brianteeman which npm version did you use?

8.19.2

avatar dgrammatiko
dgrammatiko - comment - 4 Sep 2023

@laoneo could you restore the indentation to 2 spaces instead of 4 for the package.json and the lock file?

avatar laoneo
laoneo - comment - 4 Sep 2023

Reverted the last commit

avatar laoneo
laoneo - comment - 4 Sep 2023

@brianteeman which npm version did you use?

8.19.2

That might be the issue as I'm on 9.6.7.

avatar laoneo
laoneo - comment - 4 Sep 2023

@dgrammatiko gets the same effect, so we are fine with this pr here as I do mainly the updates
image

avatar dgrammatiko
dgrammatiko - comment - 4 Sep 2023

FWIW it's time to push node/npm as 16 that we are currently have as minimum goes EOL in few weeks. It's on my todo list

avatar laoneo
laoneo - comment - 4 Sep 2023

But I would do it on 5.0 then only.

avatar laoneo laoneo - change - 4 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-04 12:21:34
Closed_By laoneo
avatar laoneo laoneo - close - 4 Sep 2023
avatar laoneo laoneo - merge - 4 Sep 2023

Add a Comment

Login with GitHub to post a comment