Feeling Lucky
?
PR-4.3-dev
[#41509] - [4.3] Tags: Don't put NULL into trim()
- Fixed in Code Base
- 30 Aug 2023
- Medium
- Build: 4.3-dev
- # 41509
- Diff
- Hackwar:4.3-tags-searchajax
User tests: Successful: Unsuccessful:
Pull Request for Issue #41466.
Summary of Changes
When on PHP 8.1 and editing an article, adding an unknown tag triggers an AJAX call which throws a notice.
Testing Instructions
- You have to be on PHP 8.1 or higher
- Edit an article and click into the tags field
- Open the browser console to see the ajax request
- Type a random tag-name into the tag field
- See the request in the console and check the request answer
Actual result BEFORE applying this Pull Request
A notice is thrown and the JS actually throws an error, too.
Expected result AFTER applying this Pull Request
No notice, everything is hunky dorry. ?
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
| Status | New | ⇒ | Pending |
chmst
- comment
- 29 Aug 2023
I have tested this item ✅ successfully on 149d153
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41509.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 29 Aug 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41509.
Quy
- | Labels |
Added:
?
PR-4.3-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-30 10:28:05 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 30 Aug 2023
Thanks!
I have tested this item ✅ successfully on 149d153
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41509.