[#41507] - [5.3] Improve Multilanguage::getSiteHomePages()
- Pending
- Medium
- Build: 4.3-dev
- # 41507
- Diff
- Denitz:patch-8
User tests: Successful: Unsuccessful:
Summary of Changes
Joomla\CMS\Language\Multilanguage::getSiteHomePages() uses an extra database query per each page load to discover the language-specific site homepages.
We can easily eliminate this extra database query and use the native SiteMenu::getItems().
Testing Instructions
Test a website with enabled multilanguage functionality and Joomla system caching enabled.
Actual result BEFORE applying this Pull Request
See an extra unoptimized SQL query per each page load:
SELECT `language`,`id` FROM `jos_menu` WHERE `home` = '1' AND `published` = 1 AND `client_id` = 0
Expected result AFTER applying this Pull Request
No extra SQL query, the homepages are discovered from the cached menu items.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
| Category | Libraries | ⇒ | Unit Tests Repository Administration com_admin SQL |
| Category | Unit Tests Repository Administration com_admin SQL | ⇒ | Libraries |
| Title |
|
||||||
| Title |
|
||||||
I have tested this item ✅ successfully on 9ea35c7
Extra query has gone.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41507.
I have tested this item ✅ successfully on 9ea35c7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41507.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41507.
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
| Labels |
Added:
Feature
RTC
b/c break
PR-5.2-dev
Removed: PR-4.3-dev |
||
This was discussed at the maintainers meeting today. Please don't remove the parameter but make a depeciated message for the parameter so that we can remove it in one of the next versions. Beside this the change is approved. Thanks.
| Status | Ready to Commit | ⇒ | Pending |
| Labels |
Added:
Updates Requested
Removed: RTC |
||
@rdeutz Done. Note that I can't add @deprecated attribute because it deprecates the whole method.
| Labels |
Removed:
Updates Requested
|
||
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
Tests are still valid the last change was only a doc block change
| Labels |
Added:
PR-5.3-dev
Removed: b/c break PR-5.2-dev |
||
This pull request has been automatically rebased to 5.1-dev.