User tests: Successful: Unsuccessful:
Joomla\CMS\Language\Multilanguage::getSiteHomePages()
uses an extra database query per each page load to discover the language-specific site homepages.
We can easily eliminate this extra database query and use the native SiteMenu::getItems()
.
Test a website with enabled multilanguage functionality and Joomla system caching enabled.
See an extra unoptimized SQL query per each page load:
SELECT `language`,`id` FROM `jos_menu` WHERE `home` = '1' AND `published` = 1 AND `client_id` = 0
No extra SQL query, the homepages are discovered from the cached menu items.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Category | ⇒ | Libraries |
Status | New | ⇒ | Pending |
Labels |
Added:
PR-4.3-dev
|
Category | Libraries | ⇒ | Unit Tests Repository Administration com_admin SQL |
Category | Unit Tests Repository Administration com_admin SQL | ⇒ | Libraries |
Title |
|
Title |
|
I have tested this item ✅ successfully on 9ea35c7
Extra query has gone.
I have tested this item ✅ successfully on 9ea35c7
Status | Pending | ⇒ | Ready to Commit |
RTC
This pull request has been automatically rebased to 5.2-dev.
Title |
|
Labels |
Added:
Feature
RTC
b/c break
PR-5.2-dev
Removed: PR-4.3-dev |
This was discussed at the maintainers meeting today. Please don't remove the parameter but make a depeciated message for the parameter so that we can remove it in one of the next versions. Beside this the change is approved. Thanks.
This pull request has been automatically rebased to 5.1-dev.