? Language Change PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar tecpromotion
tecpromotion
28 Aug 2023

Summary of Changes

There was a request in a local translation to remove the dot at the end. Users would understand the dot as part of the username and this leads to confusion.

Testing Instructions

.

Actual result BEFORE applying this Pull Request

COM_USERS_EMAIL_USERNAME_REMINDER_BODY="Hello,\n\nA username reminder has been requested for your {SITENAME} account.\n\nYour username is {USERNAME}.\n\nTo login to your account, select the link below.\n\n{LINK_TEXT} \n\nThank you."

Expected result AFTER applying this Pull Request

COM_USERS_EMAIL_USERNAME_REMINDER_BODY="Hello,\n\nA username reminder has been requested for your {SITENAME} account.\n\nYour username is {USERNAME}\n\nTo login to your account, select the link below.\n\n{LINK_TEXT} \n\nThank you."

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 28 Aug 2023
Category Language & Strings
avatar tecpromotion tecpromotion - open - 28 Aug 2023
avatar tecpromotion tecpromotion - change - 28 Aug 2023
Status New Pending
avatar heelc29 heelc29 - test_item - 29 Aug 2023 - Tested successfully
avatar heelc29
heelc29 - comment - 29 Aug 2023

I have tested this item ✅ successfully on 6586594


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41503.

avatar tecpromotion tecpromotion - change - 29 Aug 2023
Labels Added: Language Change PR-4.3-dev
avatar Quy Quy - test_item - 29 Aug 2023 - Tested successfully
avatar Quy
Quy - comment - 29 Aug 2023

I have tested this item ✅ successfully on 6586594


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41503.

avatar heelc29 heelc29 - test_item - 3 Sep 2023 - Tested successfully
avatar heelc29
heelc29 - comment - 3 Sep 2023

I have tested this item ✅ successfully on 0e80d7e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41503.

avatar Quy Quy - alter_testresult - 3 Sep 2023 - Quy: Tested successfully
avatar Quy Quy - change - 3 Sep 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 3 Sep 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41503.

avatar Quy Quy - change - 3 Sep 2023
Labels Added: ?
avatar obuisard obuisard - change - 4 Sep 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-04 14:25:55
Closed_By obuisard
avatar obuisard obuisard - close - 4 Sep 2023
avatar obuisard obuisard - merge - 4 Sep 2023
avatar obuisard
obuisard - comment - 4 Sep 2023

Thank you Stefan @tecpromotion!

Add a Comment

Login with GitHub to post a comment