[#41500] - [5.0] Joomla content plugin: Check if param is set before comparing
- Fixed in Code Base
- 2 Sep 2023
- Medium
- Build: 5.0-dev
- # 41500
- Diff
- Hackwar:5.0-joomla-content
User tests: Successful: Unsuccessful:
Summary of Changes
When adding a menu item to edit/creates articles, this code checks if the parameter enable_category is equal to 1 and if the catid is set. However, when you add this code not via the menu manager, but manually via some script, it will throw a notice when that parameter is not set. This PR adds a simple check if that param is present before comparing it. Since not setting this equals to 0, this should be fine.
Testing Instructions
Right now, before #41489 is merged, the testing sampledata can not be run, because that parameter is missing. So, install Joomla and run the testing sampledata.
Actual result BEFORE applying this Pull Request
Adding the testing sampledata fails with a notice in the AJAX call.
Expected result AFTER applying this Pull Request
Now it works.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
thanks
| Labels |
Added:
PR-5.0-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-02 18:53:08 |
| Closed_By | ⇒ | HLeithner |
thanks
I have tested this item ✅ successfully on 807c364
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41500.