Feeling Lucky
Feature
PR-5.0-dev
[#41495] - [5.0][Events] Custom fields event classes
- Fixed in Code Base
- 2 Sep 2023
- Medium
- Build: 5.0-dev
- # 41495
- Diff
- Fedik:event-custon-fields
User tests: Successful: Unsuccessful:
Summary of Changes
Event classes for Custom fields.
Affected events:
- onCustomFieldsGetTypes
- onCustomFieldsPrepareDom
- onCustomFieldsBeforePrepareField
- onCustomFieldsPrepareField
- onCustomFieldsAfterPrepareField
Testing Instructions
Use custom fields
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
- Documentation link for docs.joomla.org: https://docs.joomla.org/Plugin/Events#Fields
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: joomla/Manual#177
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_fields Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Feature
PR-5.0-dev
b/c break
|
||
| Labels |
Removed:
b/c break
|
||
| Category | Administration com_fields Libraries | ⇒ | Administration com_fields Libraries Front End Plugins |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-02 14:15:11 |
| Closed_By | ⇒ | HLeithner |
Fedik
- comment
- 2 Sep 2023
This is unnecessary, whole legacy listeners code should go, not only for FieldsPlugin.
HLeithner
- comment
- 3 Sep 2023
yes but that means we have to call $y = $event->getY() anyway when we don't have references anymore. In this case maybe it make sense to not have (pseudo)references at the caller location at all and always run $x = $event->getX() for every reference/proxyArray we use now?
Fedik
- comment
- 3 Sep 2023
You comented in wrong PR :)
Merging this as with code review and based on the other similar PRs, before beta1 to get enough feedback for final release.
Additionally we need a deprecation warning for plugins which extend the
FieldsPluginwithout the subscriber interface.Suggestion, create a constructor function which test if $this is instance of SubscriberInterface.