Feeling Lucky
?
bug
PR-4.4-dev
[#41472] - [4] Remove $db->quote call in com_contact query
- Fixed in Code Base
- 28 Aug 2023
- Medium
- Build: 4.4-dev
- # 41472
- Diff
- SniperSister:4x-remove-quote-call
User tests: Successful: Unsuccessful:
Summary of Changes
While developing #41470 I looked for similar filtering calls in the codebase and realized that the $db->quote, that I removed in this PR has to be removed because otherwise items assigned to "All" languages won't be filtered. The quote seems to date back to a non-prepared-statement version of the query where it made sense, in the new version however it causes the query to include WHERE IN ("en-GB", "\"*\"") which doesn't match with * what's stored in the DB.
The change is trivial, therefore no detailed testing instructions provided.
Testing Instructions
Code Review
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
alikon
- comment
- 27 Aug 2023
I have tested this item ✅ successfully on 9847e76
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41472.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 27 Aug 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41472.
| Labels |
Added:
?
bug
PR-4.4-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-28 11:10:59 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 28 Aug 2023
Thanks!
I have tested this item ✅ successfully on 9847e76
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41472.