? Language Change bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
26 Aug 2023

Pull Request for Issue #28239.

Summary of Changes

Depending on the language and smart search settings, smart search might find a lot of compound words and tokens for a small search entry. These tokens then are all converted into code for the highlighting script, which is then added to the URL of each search result. In worst case, this can make the URL to long to be processed by the webserver. This PR limits the maximum amount of tokens to 10, so that doesn't get out of hand. Yes, this does mean, that some terms, which would be part of the search result, don't get highlighted, but I'd rather have some terms not highlighted than the page breaking completely.

Testing Instructions

Search for something with more than 10 different words, for example in the test sampledata "Thanks for helping us to test Joomla! We're getting ready for the release of Joomla and we appreciate you helping us". Look at the sourcecode of the page and look for the block containing "class": "js-highlight",. Below you will find a list of all search terms it is highlighting.

Actual result BEFORE applying this Pull Request

The list contains more than 10 words, in the case of the above search phrase it is 23.

Expected result AFTER applying this Pull Request

The list is limited to 10 words.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2023
Category Front End com_finder
avatar Hackwar Hackwar - open - 26 Aug 2023
avatar Hackwar Hackwar - change - 26 Aug 2023
Status New Pending
avatar Hackwar Hackwar - change - 26 Aug 2023
Labels Added: PR-4.3-dev
avatar KingLouis1 KingLouis1 - test_item - 27 Aug 2023 - Tested successfully
avatar KingLouis1
KingLouis1 - comment - 27 Aug 2023

I have tested this item ✅ successfully on 191e612


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41463.

avatar Quy Quy - test_item - 3 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 3 Sep 2023

I have tested this item ✅ successfully on 191e612


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41463.

avatar Quy Quy - change - 3 Sep 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 3 Sep 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41463.

avatar Quy Quy - change - 3 Sep 2023
Labels Added: ? bug
avatar Quy
Quy - comment - 3 Sep 2023

Under Highlight Search Terms setting, should there be an inline help stating that up to 10 search terms will be highlighted?

avatar obuisard obuisard - change - 11 Sep 2023
Labels Added: PR-4.4-dev
Removed: PR-4.3-dev
avatar obuisard obuisard - change - 11 Sep 2023
Title
[4.3] Smart Search: Limiting highlighting of tokens
[4.4] Smart Search: Limiting highlighting of tokens
avatar obuisard obuisard - edited - 11 Sep 2023
avatar laoneo
laoneo - comment - 11 Sep 2023

@Hackwar can you update the language string mentioned by @Quy? Then I would this one is ready for the next beta.

avatar joomla-cms-bot joomla-cms-bot - change - 12 Sep 2023
Category Front End com_finder Administration com_finder Language & Strings Front End
avatar Hackwar Hackwar - change - 12 Sep 2023
Labels Added: Language Change
avatar Quy Quy - test_item - 13 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 13 Sep 2023

I have tested this item ✅ successfully on edfb611


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41463.

avatar MacJoom MacJoom - alter_testresult - 13 Sep 2023 - KingLouis1: Tested successfully
avatar MacJoom MacJoom - change - 15 Sep 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-15 08:38:34
Closed_By MacJoom
avatar MacJoom MacJoom - close - 15 Sep 2023
avatar MacJoom MacJoom - merge - 15 Sep 2023

Add a Comment

Login with GitHub to post a comment