User tests: Successful: Unsuccessful:
Pull Request for Issue #28239.
Depending on the language and smart search settings, smart search might find a lot of compound words and tokens for a small search entry. These tokens then are all converted into code for the highlighting script, which is then added to the URL of each search result. In worst case, this can make the URL to long to be processed by the webserver. This PR limits the maximum amount of tokens to 10, so that doesn't get out of hand. Yes, this does mean, that some terms, which would be part of the search result, don't get highlighted, but I'd rather have some terms not highlighted than the page breaking completely.
Search for something with more than 10 different words, for example in the test sampledata "Thanks for helping us to test Joomla! We're getting ready for the release of Joomla and we appreciate you helping us". Look at the sourcecode of the page and look for the block containing "class": "js-highlight",
. Below you will find a list of all search terms it is highlighting.
The list contains more than 10 words, in the case of the above search phrase it is 23.
The list is limited to 10 words.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Category | ⇒ | Front End com_finder |
Status | New | ⇒ | Pending |
Labels |
Added:
PR-4.3-dev
|
I have tested this item ✅ successfully on 191e612
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
bug
|
Under Highlight Search Terms
setting, should there be an inline help stating that up to 10 search terms will be highlighted?
Labels |
Added:
PR-4.4-dev
Removed: PR-4.3-dev |
Title |
|
Category | Front End com_finder | ⇒ | Administration com_finder Language & Strings Front End |
Labels |
Added:
Language Change
|
I have tested this item ✅ successfully on edfb611
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-15 08:38:34 |
Closed_By | ⇒ | MacJoom |
I have tested this item ✅ successfully on 191e612
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41463.