[#41461] - Change hover color of links in footer
- Closed
- 24 Oct 2023
- Medium
- Build: 4.3-dev
- # 41461
- Diff
- MagnusSinger:i41172
User tests: Successful: Unsuccessful:
Pull Request for Issue #41172.
Summary of Changes
The color of the links stay the same when one hovers or focusses them
Testing Instructions
Create a footer module and hover over the links, the color should not change
Actual result BEFORE applying this Pull Request
The color went to a not readable one when the user hovered the links in the footer
Expected result AFTER applying this Pull Request
The color now stays constant
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Status | New | ⇒ | Pending |
I have not tested this item.
Issue could be reproduced.
But the patch could not be applied. The following message was pops up: "The file marked for modification does not exist: build/media_source/templates/site/cassiopeia/scss/blocks/_footer.scss"
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41461.
@KingLouis1 maybe try it with a fresh install of 4.3? The file must be there: https://github.com/joomla/joomla-cms/blob/4.3-dev/build/media_source/templates/site/cassiopeia/scss/blocks/_footer.scss
See #40435 (comment)
Does this mean this PR can be closed?
Does this mean this PR can be closed?
I'll wait for comments before I try another PR.
[EDIT If yes, then this pr is unnecessary]
This pull request has been automatically rebased to 4.4-dev.
thanks for your work @MagnusSinger but I'm closing this in favor for #41749 as suggested by allon and viviana
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-24 13:25:41 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
NPM Resource Changed
PBF
bug
PR-4.4-dev
|
||
See #40435 (comment)