[#41458] - [5.1] Template-param-brand
- Fixed in Code Base
- 11 May 2024
- Medium
- Build: 5.0-dev
- # 41458
- Diff
- chmst:template-param-brand
User tests: Successful: Unsuccessful:
Pull Request for Issue #37352 .
Summary of Changes
Change the filter for brand to "options".
Testing Instructions
see #37352.
Actual result BEFORE applying this Pull Request
{"brand":"true", in database after updating a template copy
Expected result AFTER applying this Pull Request
{"brand":"1"," after updating a template copy
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
I would like to clarify first what is "true" and what is "false", in joomla we have a bunch of diffrent implementation what means "false" as string false as boolean and "0" as string and int and yes or no at least it's not always handled the same.
In this case saving a bool as 0 and 1 seems to be the right thing, problem could be using it in a different like
in this example https://3v4l.org/PSoL5
So we should check the complete codebase for inconsistency and find a solution normalize this. Pretty sure someone did this already and the PR has not been merged or has been closed or is still open don't know.
I bring this topic up in the next maintainer meeting.
For now I target this pr for 5.0.1
I would suggets to stick with 1/0, for XML, and use filter="INT"
This is more safe. When the data is loaded from database again to the field, the field may not understand what is true/false, because it expect 1/0
I have tested this item ✅ successfully on 8f84067
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41458.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41458.
| Labels |
Added:
RTC
bug
RMDQ
PR-5.0-dev
Small
|
||
| Title |
|
||||||
| Labels |
Added:
PR-5.1-dev
Removed: PR-5.0-dev |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-11 20:29:01 |
| Closed_By | ⇒ | bembelimen |
Thanks
I have tested this item ✅ successfully on 8f84067
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41458.