Feeling Lucky
PR-4.4-dev
[#41447] - more flexible Bootstrap modal component
- Closed
- 26 Aug 2023
- Medium
- Build: 4.4-dev
- # 41447
- Diff
- stell:4.4-dev
User tests: Successful: Unsuccessful:
Summary of Changes
Possibility to make the bootstrap modal component more flexible by adding classes to modal-dialog described here:
https://getbootstrap.com/docs/5.3/components/modal/
Nothing changes if not used.
Testing Instructions
echo HTMLHelper::_(
'bootstrap.renderModal',
'log-1',
['title' => 'Title', 'modalDialogClass' => 'modal-dialog-centered modal-xl modal-dialog-scrollable'],
'<div class="p-3"><div class="row"><div>Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua.</div></div></div>'
);
Actual result BEFORE applying this Pull Request
hardcoded modal layout classes
Expected result AFTER applying this Pull Request
vertically centered, scrollable inside and wider
joomla-cms-bot
- | Category | ⇒ | Layout |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-26 08:42:06 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
PR-4.4-dev
|
||
laoneo
- comment
- 26 Aug 2023
Thanks for your contribution. Closing this one as we have a similar one in 5.
There is an already merged PR for 5.0 #40650