PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
22 Aug 2023

Pull Request for Issue # .

Summary of Changes

Fix JSON error when updating with a PostgreSQL database and add explaining comment to update SQL script for MySQL to explain why it's different to the same value in base.sql.

Testing Instructions

For MySQL code review is sufficient.

On PostgreSQL, update from 4.4 and then check if the filter parameter of the fields plugins "textarea" and "editor" have been migrated correwctly (with "\" in the database in the filter parameter.

Create a new custom field for

Actual result BEFORE applying this Pull Request

Update succeeds on MySQL.

On PostgreSQL it fails with an yellow warning alert:

JInstaller: :install: Error SQL 22P02, 7, ERROR: invalid input syntax for type json LINE 2: ...params" = jsonb_set("params"::jsonb, '{filter}' , '"\\Joomla... ^ DETAIL: Escape sequence "\J" is invalid. CONTEXT: JSON data, line 1: "\J...

Expected result AFTER applying this Pull Request

Update still succeeds on MySQL.

Update succeeds without any warning or error on PostgreSQL.

Custom fields of types editor, text and textarea work with the "Text" filter.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 22 Aug 2023
Category SQL Administration com_admin Postgresql
avatar richard67 richard67 - open - 22 Aug 2023
avatar richard67 richard67 - change - 22 Aug 2023
Status New Pending
avatar richard67 richard67 - change - 22 Aug 2023
Labels Added: PR-5.0-dev
avatar HLeithner HLeithner - change - 22 Aug 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-22 10:47:05
Closed_By HLeithner
avatar HLeithner HLeithner - close - 22 Aug 2023
avatar HLeithner HLeithner - merge - 22 Aug 2023
avatar HLeithner
HLeithner - comment - 22 Aug 2023

thanks

Add a Comment

Login with GitHub to post a comment