? Success

User tests: Successful: Unsuccessful:

avatar purplebeanie
purplebeanie
22 Aug 2014

Hi Folks

A very, very small fix for Issue #2701 as reported by @lahmizzar.

Just starting to get my toes wet with contributing to Joomla via Github so I hope I have done this properly?

Cheers,
Eric.

avatar purplebeanie purplebeanie - open - 22 Aug 2014
avatar jissues-bot jissues-bot - change - 22 Aug 2014
Status Pending New
Labels Added: ?
avatar Bakual
Bakual - comment - 22 Aug 2014

The PR is fine. If you can add test instructions it will be perfect. Thank you!

avatar purplebeanie
purplebeanie - comment - 22 Aug 2014

Great thanks.

###Test instructions###

To test login in to Joomla admin and from top menu bar select the Edit Account under the gear icon.

Click the "Refresh" button next to Help Site with Chrome Dev tools or Firebug open. The URL for the XHR should only have one "/" before the index.php.... rather than the double slash as reported in the original ticket.

4143-testing-success

avatar infograf768 infograf768 - change - 22 Aug 2014
Status New Pending
avatar sonkoral
sonkoral - comment - 22 Aug 2014

Just applied patch and followed test instructions, but the refresh button doesn't seem to do anything now. The console doesn't populate the expected URL.
no-result

avatar purplebeanie
purplebeanie - comment - 23 Aug 2014

Hi @sonkoral .... Thansk for testing.

Okay, it looks like you actually have logging of XMLHTTPRequests turned off. On Chrome you need to turn it on separately.

To turn logging of XMLHTTPRequests on click on the little cog icon on the top right of developer tools. Go to General under the Settings on the left and click General (it should open by default). The on the right hand side at the bottom make sure the Log XMLHttpRequests box is checked.
doubleslash-2

Cheers,
Eric.

avatar brianteeman
brianteeman - comment - 24 Aug 2014

@test
After enabling XMLHTTPRequests logging I could see the // and can confirm that the patch resolves this

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar sonkoral
sonkoral - comment - 24 Aug 2014

Thanks for the pointer in Firebug! Confirmed patch eliminates the double slashes as well.

avatar brianteeman brianteeman - change - 24 Aug 2014
Status Pending New
Labels Added: ?
avatar brianteeman
brianteeman - comment - 24 Aug 2014

2 good tests setting RTC

avatar Bakual Bakual - change - 24 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-24 12:22:44
avatar Bakual Bakual - close - 24 Aug 2014
avatar Bakual Bakual - close - 24 Aug 2014
avatar Bakual
Bakual - comment - 24 Aug 2014

Merged, thanks!

Add a Comment

Login with GitHub to post a comment