Feature PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
21 Aug 2023

Rebased and squashed #41297

Summary of Changes

Implementing Event classes for Module events.
The pr depend from #41226

Affected events:

  • onRenderModule
  • onAfterRenderModule
  • onAfterRenderModules
  • onPrepareModuleList
  • onAfterModuleList
  • onAfterCleanModuleList

Backward compatibility break (not critical):

Affects onAfterRenderModules.
Because its is imposible to pass the event attribute by reference the event listener now should use
$event->getContent() and $event->setContent($content) when need to modify the output.

Testing Instructions

Apply patch. Check all works

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2023
Category Administration com_users Libraries
avatar Fedik Fedik - open - 21 Aug 2023
avatar Fedik Fedik - change - 21 Aug 2023
Status New Pending
avatar Fedik Fedik - change - 21 Aug 2023
The description was changed
avatar Fedik Fedik - edited - 21 Aug 2023
avatar HLeithner HLeithner - change - 21 Aug 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-21 08:21:54
Closed_By HLeithner
Labels Added: Feature PR-5.0-dev
avatar HLeithner HLeithner - close - 21 Aug 2023
avatar HLeithner HLeithner - merge - 21 Aug 2023
avatar HLeithner
HLeithner - comment - 21 Aug 2023

thanks

avatar Fedik Fedik - change - 22 Aug 2023
The description was changed
avatar Fedik Fedik - edited - 22 Aug 2023
avatar Fedik Fedik - change - 29 Aug 2023
The description was changed
avatar Fedik Fedik - edited - 29 Aug 2023

Add a Comment

Login with GitHub to post a comment