PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
20 Aug 2023

Pull Request for Issue #41399 .

Summary of Changes

Minimum set to 0 and only numbers are allowed

Testing Instructions

Add a recipe and try a negative and or decimal duration

Actual result BEFORE applying this Pull Request

nothing

Expected result AFTER applying this Pull Request

marked invalid on blur

avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2023
Category Front End Plugins
avatar HLeithner HLeithner - open - 20 Aug 2023
avatar HLeithner HLeithner - change - 20 Aug 2023
Status New Pending
avatar brianteeman brianteeman - test_item - 20 Aug 2023 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 20 Aug 2023

No change

image

avatar brianteeman
brianteeman - comment - 20 Aug 2023

I have tested this item ? unsuccessfully on 9dba891


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41405.

avatar brianteeman
brianteeman - comment - 20 Aug 2023

pattern does not work on number fields

avatar brianteeman
brianteeman - comment - 20 Aug 2023

also you have told me many times in the past that clientside only validation is not good enough

avatar HLeithner
HLeithner - comment - 20 Aug 2023

pattern does not work on number fields

Interesting, j read it doesn't work in chrome, I tested it in Vivaldi and thought it's fixed for all chromium based browsers.

Also interesting that joomla doesn't validate it patterns, have to check this, don't we have a regex validation?

avatar brianteeman
brianteeman - comment - 20 Aug 2023

i've lost track now of the number of times over the years I have raised that forms are not being validated when we think they are and vice versa.

avatar brianteeman
brianteeman - comment - 20 Aug 2023

pattern does not work on number fields

Interesting, j read it doesn't work in chrome, I tested it in Vivaldi and thought it's fixed for all chromium based browsers.

Nothing to do with chrome. its part of the specification

the pattern attribute is an attribute of the text, tel, email, url, password, and search input types.
https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/pattern

avatar dgrammatiko
dgrammatiko - comment - 20 Aug 2023

Also interesting that joomla doesn't validate it patterns

Validation per field is OPT-IN, not default...

avatar HLeithner
HLeithner - comment - 20 Aug 2023

you are right that pr doesn't solve the issue, mainly because we don't have a correct field for this. In theory we have a time field with time rule which would fit, with the exception that the maximum could only be 24 hours and can't be easily extended to more then 99 ours...

Also we are missing a simple regex rule...

I'm closing this pr. sorry for wasting your time.

avatar HLeithner HLeithner - close - 20 Aug 2023
avatar HLeithner HLeithner - change - 20 Aug 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-08-20 19:19:05
Closed_By HLeithner
Labels Added: PR-5.0-dev

Add a Comment

Login with GitHub to post a comment