bug ? PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
20 Aug 2023

Pull Request for Issue #41392, #38355

Summary of Changes

set correct relation from tag id to tag title

Testing Instructions

see #41392

Actual result BEFORE applying this Pull Request

no match for tagIDs/names

Expected result AFTER applying this Pull Request

matching tagIDs/names

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2023
Category Libraries
avatar alikon alikon - open - 20 Aug 2023
avatar alikon alikon - change - 20 Aug 2023
Status New Pending
avatar alikon alikon - change - 20 Aug 2023
The description was changed
avatar alikon alikon - edited - 20 Aug 2023
avatar alikon alikon - change - 18 Sep 2023
Labels Added: bug ? PR-4.3-dev
avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2023
Category Libraries
avatar alikon alikon - change - 18 Sep 2023
The description was changed
avatar alikon alikon - edited - 18 Sep 2023
avatar alikon alikon - change - 18 Sep 2023
Labels Added: PR-4.4-dev
Removed: PR-4.3-dev
avatar MacJoom
MacJoom - comment - 18 Sep 2023

@alikon Thanks for the PR - while it works this way i would prefer a cleaner solution in the TagsHelper class with a new function e.g. getTags returning the array with the corresponding id's from the beginning without having to loop again

avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2023
Category Libraries
19e6f00 19 Sep 2023 avatar alikon cs
avatar alikon
alikon - comment - 19 Sep 2023

@MacJoom created a new function in the tagshelper as requested

avatar MacJoom MacJoom - change - 25 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-25 17:42:21
Closed_By MacJoom
avatar MacJoom MacJoom - close - 25 Sep 2023
avatar MacJoom MacJoom - merge - 25 Sep 2023

Add a Comment

Login with GitHub to post a comment