PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
19 Aug 2023

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the lists of files and folders to be deleted on update in file "administrator/components/com_admin/script.php" to recent changes in the 5.0-dev branch in preparation for the upcoming 5.0.0-alpha4 release.

In detail deleted files and folder from following PR's are added:

  • PR #41321 empty folders
    '/templates/system/incompatible.html,/includes',
    '/templates/system/incompatible.html,',
  • PR #41289 folder '/media/plg_editors_tinymce/js/plugins/highlighter' and all files in that folder.

The following is not added due to deliberate decisions of the release managers:

  • PR #41260 renamed file '/plugins/schemaorg/blogposting/src/Extension/Blogposting.php'
    Decision see #41261 (comment) .
  • PR #41276 deleted files and folder and uninstalling the obsolete system plugin on update
    Decision see #41276 (comment) .

The file from the first point not being renamed might cause schema.org for blog posts not working on Windows hosts after updates from previous 5.0 alpha versions.

The second point leaves an obsolete system plugin installed, which might cause issues when being activated when updating, and also after the update.

Therefore I have created PR #41394 to fix both mentioned points in case if the release managers think over their decision. That PR also includes the changes from this one here.

Testing Instructions

Code review.

Or if you want to make a real test, update a current 4.4-dev nightly build or a 5.0.0-alpha3 to the last 5.0 nightly build to get the actual result, and update a current 4.4-dev nightly build or a 5.0.0-alpha3 to the update package built by Drone for this PR to get the expected result.

Actual result BEFORE applying this Pull Request

The files and folders mentioned above are still present after updating from a current 4.4-dev nightly build or a 5.0.0-alpha3.

Expected result AFTER applying this Pull Request

The files and folders mentioned above have been deleted after updating from a current 4.4-dev nightly build or a 5.0.0-alpha3.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2023
Category Administration com_admin
avatar richard67 richard67 - open - 19 Aug 2023
avatar richard67 richard67 - change - 19 Aug 2023
Status New Pending
avatar richard67 richard67 - change - 19 Aug 2023
The description was changed
avatar richard67 richard67 - edited - 19 Aug 2023
avatar richard67 richard67 - change - 19 Aug 2023
The description was changed
avatar richard67 richard67 - edited - 19 Aug 2023
avatar richard67 richard67 - change - 19 Aug 2023
The description was changed
avatar richard67 richard67 - edited - 19 Aug 2023
avatar richard67 richard67 - change - 19 Aug 2023
The description was changed
avatar richard67 richard67 - edited - 19 Aug 2023
avatar richard67 richard67 - change - 19 Aug 2023
The description was changed
avatar richard67 richard67 - edited - 19 Aug 2023
avatar brianteeman
brianteeman - comment - 19 Aug 2023

i hope the release manager comes to their senses!

avatar richard67 richard67 - change - 19 Aug 2023
The description was changed
avatar richard67 richard67 - edited - 19 Aug 2023
avatar richard67 richard67 - change - 19 Aug 2023
The description was changed
avatar richard67 richard67 - edited - 19 Aug 2023
avatar richard67 richard67 - change - 20 Aug 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-08-20 19:39:55
Closed_By richard67
Labels Added: PR-5.0-dev
avatar richard67
richard67 - comment - 20 Aug 2023

Closing in favor of the just merged PR #41394 .

avatar richard67 richard67 - close - 20 Aug 2023

Add a Comment

Login with GitHub to post a comment