Feeling Lucky
bug
?
PR-4.4-dev
[#41371] - [4.4] Ensure dispatcher are set. For backward compatibility with legacy components
- Fixed in Code Base
- 16 Aug 2023
- Medium
- Build: 4.4-dev
- # 41371
- Diff
- Fedik:mode-dispatcher-fix
User tests: Successful: Unsuccessful:
Summary of Changes
BaseDatabaseModel implements DispatcherAwareInterface, but MVC does not guarantee that dispatcher will available for legacy components.
Testing Instructions
Apply patch. Install patchtester.
Edit libraries/src/MVC/Model/ListModel.php getFilterForm() method, add $this->getDispatcher();
Open /administrator/index.php?option=com_patchtester
Actual result BEFORE applying this Pull Request
And error Dispatcher not set in Joomla\CMS\MVC\Model\BaseDatabaseModel
Expected result AFTER applying this Pull Request
No error
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
Fedik
- comment
- 15 Aug 2023
It deprecated both if and else, so I see no point :)
I mean whole block should be removed in 6.0
Fedik
- comment
- 15 Aug 2023
hmhm, all tests are gone wild
| Labels |
Added:
bug
?
PR-4.4-dev
|
||
Fedik
- comment
- 15 Aug 2023
It is good now
Fedik
- comment
- 15 Aug 2023
I have changed the approach, now should be better.
MacJoom
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-16 17:09:03 |
| Closed_By | ⇒ | MacJoom |
I think the deprecation trigger should be moved into the if statement