? bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar ManuelHu
ManuelHu
14 Aug 2023

Pull Request for Issue #41368.

Summary of Changes

re-add the minus sign to the list of allowed characters, that had been removed in PR #38987.

It restores the behavior that is also described in the error message for in valid filenames.

Testing Instructions

  • Open a template in the com_templates file browser
  • Try to create a (e.g. PHP) file that contains a minus sign, e.g. enter contains-minus as a file name

Actual result BEFORE applying this Pull Request

The file is not created, and an error message is shown:

COM_TEMPLATES_INVALID_FILE_NAME="Invalid file name. Please choose a file name with a-z, A-Z, 0-9, ., - and _."

Expected result AFTER applying this Pull Request

The file contains-minus.php is created. This is a totally valid filename.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2023
Category Administration com_templates
avatar ManuelHu ManuelHu - open - 14 Aug 2023
avatar ManuelHu ManuelHu - change - 14 Aug 2023
Status New Pending
avatar Quy Quy - test_item - 14 Aug 2023 - Tested successfully
avatar Quy
Quy - comment - 14 Aug 2023

I have tested this item successfully on 7dbd75e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41369.

avatar Fedik Fedik - test_item - 16 Aug 2023 - Tested successfully
avatar Fedik
Fedik - comment - 16 Aug 2023

I have tested this item ✅ successfully on 7dbd75e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41369.

avatar Fedik Fedik - change - 16 Aug 2023
Status Pending Ready to Commit
avatar Fedik
Fedik - comment - 16 Aug 2023

r2c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41369.

avatar rdeutz rdeutz - change - 16 Aug 2023
Labels Added: ? bug PR-4.3-dev
avatar rachelwalraven rachelwalraven - test_item - 26 Aug 2023 - Tested successfully
avatar rachelwalraven
rachelwalraven - comment - 26 Aug 2023

I have tested this item ✅ successfully on 1546592


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41369.

avatar obuisard obuisard - close - 29 Aug 2023
avatar obuisard obuisard - merge - 29 Aug 2023
avatar obuisard obuisard - change - 29 Aug 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-29 17:30:12
Closed_By obuisard
avatar obuisard
obuisard - comment - 29 Aug 2023

Thank you Manuel @ManuelHu for the rectification!

Add a Comment

Login with GitHub to post a comment