Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41364] - [5.0] fix joomla update not download url

PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
13 Aug 2023

Summary of Changes

property downloadurl is protected since #41118 by @alikon

so the check fails here now

joomla-cms/administrator/components/com_joomlaupdate/src/View/Joomlaupdate/HtmlView.php

Line 177 in 3fa34be

$hasDownload = isset($this->updateInfo['object']->downloadurl->_data);

Testing Instructions

enter Custom URL for joomla update, for eg. of this pull request
image

click on joomla update quickicon which shows that an update is available
image

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2023
Category ⇒ Libraries
avatar heelc29 heelc29 - open - 13 Aug 2023
avatar heelc29 heelc29 - change - 13 Aug 2023
Status New ⇒ Pending
avatar alikon alikon - test_item - 14 Aug 2023 - Tested successfully
avatar alikon
alikon - comment - 14 Aug 2023

I have tested this item ✅ successfully on 2ddec12

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41364.

avatar HLeithner HLeithner - change - 14 Aug 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-08-14 07:00:36
Closed_By ⇒ HLeithner
Labels Added: PR-5.0-dev
avatar HLeithner HLeithner - close - 14 Aug 2023
avatar HLeithner HLeithner - merge - 14 Aug 2023
avatar HLeithner
HLeithner - comment - 14 Aug 2023

Thanks

Add a Comment

Login with GitHub to post a comment