bug ? PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
13 Aug 2023

Summary of Changes

Same as #41345 but for 4.4.
Fixing possible b/c break for an events.
I have extracted it from #41226 in to separated PR.

Testing Instructions

Apply patch.
Edit plugins/system/sef/src/Extension/Sef.php, add return true; at top of onAfterDispatch() function.
Run in index.php of a template:

$event = new class('onAfterDispatch') extends Joomla\CMS\Event\AbstractImmutableEvent{};
$app->getDispatcher()->dispatch('onAfterDispatch', $event);

Actual result BEFORE applying this Pull Request

An error, cannot set result for Imutable event

Expected result AFTER applying this Pull Request

No error

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: joomla/Manual#169
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2023
Category Libraries
avatar Fedik Fedik - open - 13 Aug 2023
avatar Fedik Fedik - change - 13 Aug 2023
Status New Pending
avatar Fedik Fedik - change - 13 Aug 2023
The description was changed
avatar Fedik Fedik - edited - 13 Aug 2023
avatar HLeithner HLeithner - test_item - 14 Aug 2023 - Tested successfully
avatar HLeithner
HLeithner - comment - 14 Aug 2023

I have tested this item successfully on d09f3e1

Works with patchtester which broke before


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41357.

avatar laoneo laoneo - change - 14 Aug 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-14 10:57:09
Closed_By laoneo
Labels Added: bug ? PR-4.4-dev
avatar laoneo laoneo - close - 14 Aug 2023
avatar laoneo laoneo - merge - 14 Aug 2023
avatar laoneo
laoneo - comment - 14 Aug 2023

Merging this now. Thanks @Fedik, can you write a manual entry for the deprecation notice?

avatar Fedik
Fedik - comment - 14 Aug 2023

There it is joomla/Manual#169

avatar Fedik Fedik - change - 14 Aug 2023
The description was changed
avatar Fedik Fedik - edited - 14 Aug 2023

Add a Comment

Login with GitHub to post a comment