[#41349] - [4.3] validate="CssIdentifier"
- Fixed in Code Base
- 11 Aug 2023
- Medium
- Build: 4.3-dev
- # 41349
- Diff
- brianteeman:cssidentifier
- Pending continuous-integration/appveyor/pr Waiting for AppVeyor build to complete Details
User tests: Successful: Unsuccessful:
The majority of fields that accept a css class also have a validation rule to make sure its valid css
Some fields were missed. This PR resolves that.
To Test
Code review that the fields changed are indeed fields that should only accept css
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_fields com_menus Front End |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41349.
| Labels |
Added:
PR-4.3-dev
|
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41349.
The pr is correct, however this can break an existing user values.
Example people can use the icon field for random stuff in the layout override.
I would not do it in patch release. It is for 4.4 or 5.0
Example people can use the icon field for random stuff in the layout override.
do we really have to care about people doing stupid things?
Anyway its upto the maintainers where it is merged
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-11 21:11:34 |
| Closed_By | ⇒ | obuisard |
Thank you Brian @brianteeman for the PR!
I have tested this item✅ successfully on f18b5f2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41349.