Feeling Lucky
bug
PR-5.0-dev
?
[#41345] - [5.0] Events backward compatibility handling
- Closed
- 13 Aug 2023
- Medium
- Build: 5.0-dev
- # 41345
- Diff
- Fedik:events-fixes1
User tests: Successful: Unsuccessful:
Summary of Changes
I have extracted b/c fixes from #41226 in to separated PR.
Testing Instructions
Apply patch.
Edit plugins/system/sef/src/Extension/Sef.php, add return true at top of onAfterDispatch() function.
Actual result BEFORE applying this Pull Request
An error, cannot set result for Imutable event
Expected result AFTER applying this Pull Request
No error
Link to documentations
Please select:
- Documentation link for docs.joomla.org: IDK
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: IDK
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
Fedik
- comment
- 10 Aug 2023
I think it is enought to check for "numeric", additional test for a string does not give us any extra value.
| Labels |
Added:
bug
PR-5.0-dev
?
|
||
HLeithner
- comment
- 12 Aug 2023
I would do this in 4.4 because it's not an intended behaviour (if we remove it in 6 then is another story)
Fedik
- comment
- 13 Aug 2023
I can redo it to 4.4, no problem
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-13 08:40:48 |
| Closed_By | ⇒ | Fedik |
Would it make sense to check if the $name is a string and numeric?
Actually only strings are allowed but we don't have a typehint for it...