? Release Blocker PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
9 Aug 2023

Pull Request for Issue #41256 .

Summary of Changes

After removing CMSObject from User class #40999, it cause weird issue when binding User data to the form.
The PR is fixing it.

Testing Instructions

Apply patch,
Make sure errror reaporting on maximum.
On the site open user profile page

Actual result BEFORE applying this Pull Request

No warnings

Expected result AFTER applying this Pull Request

Many warnings:

Warning: SimpleXMLElement::xpath(): Unfinished literal in /libraries/src/Form/Form.php on line 1250

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 9 Aug 2023
Category Libraries
avatar Fedik Fedik - open - 9 Aug 2023
avatar Fedik Fedik - change - 9 Aug 2023
Status New Pending
avatar waader waader - test_item - 26 Aug 2023 - Tested successfully
avatar waader
waader - comment - 26 Aug 2023

I have tested this item ✅ successfully on a22f55b

works for me!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41342.

avatar Quy Quy - test_item - 2 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 2 Sep 2023

I have tested this item ✅ successfully on a22f55b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41342.

avatar Quy Quy - change - 2 Sep 2023
Status Pending Ready to Commit
Labels Added: PR-5.0-dev
avatar Quy Quy - edited - 2 Sep 2023
avatar Quy
Quy - comment - 2 Sep 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41342.

avatar HLeithner
HLeithner - comment - 2 Sep 2023

Not sure if this is the right solution...

avatar HLeithner HLeithner - close - 3 Sep 2023
avatar HLeithner HLeithner - merge - 3 Sep 2023
avatar HLeithner HLeithner - change - 3 Sep 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-03 08:24:16
Closed_By HLeithner
Labels Added: ? Release Blocker
avatar HLeithner
HLeithner - comment - 3 Sep 2023

I merge this even if I'm not 100% confident with this solution. thanks

avatar HLeithner
HLeithner - comment - 3 Sep 2023

maybe the alternative is to check if the legacytrait is implemented.

avatar Fedik
Fedik - comment - 3 Sep 2023

Maybe we can implement Iterator intrface over base Table class?

avatar HLeithner
HLeithner - comment - 3 Sep 2023

hmm that's maybe an idea too

avatar Fedik
Fedik - comment - 3 Sep 2023

then it also will be possible to do $array = iterator_to_array($table) https://www.php.net/manual/en/function.iterator-to-array

Add a Comment

Login with GitHub to post a comment