Where is the code to add the task in the database for new J5.0 installations?

Where is the code to add the task in the database for new J5.0 installations?

@alikon @heelc29 is right: As on a new J5 installation the secciongc plugin would be enabled by default, it needs something like this here: https://github.com/joomla/joomla-cms/pull/40788/files#diff-fa733b616bbcc3e559d5003d630a5ba449c1cec34c00d1f44aa6d6c7d1dc75d0

Where is the code to add the task in the database for new J5.0 installations?

@alikon @heelc29 is right: As on a new J5 installation the secciongc plugin would be enabled by default, it needs something like this here: https://github.com/joomla/joomla-cms/pull/40788/files#diff-fa733b616bbcc3e559d5003d630a5ba449c1cec34c00d1f44aa6d6c7d1dc75d0

done thx for reporting

@alikon It needs again to rename the update SQL scripts, this time to something newer than "5.0.0-2023-08-21.sql". I suggest to use "5.0.0-2023-08-26.sql" for this PR here.

done

@alikon check alikon#31 please

@alikon I've solved the merge conflict caused by the recently merged globalcheckin task plugin, so before you continue to work locally on your branch you have to pull the changes from remote.

@heelc29, @richard67
thanks

@alikon I've allowed myself to update the branch and apply some small code style fix. Now I think it needs better testing instructions. I suggest something as follows for this PR here, and will later make suggestions also for the other 4 PRs. Feel free to just copy it and paste into the descriptions of the PRs, or modify them as you want.

Testing Instructions

New installation

Make a new installation with this PR applied.

Check if there is an enabled task scheduler plugin "Task - Session Data Purge".

Check if there is an enabled scheduled task "SessionGC" using that plugin.

Check that the new task shall run every 24 hours at the hour when the Joomla installation was made.

Update

On a Joomla 4.4-dev version or 4.4.0 alpha 4, note the endabled status and the configuration parameters of the "System - Session Data Purge" plugin.

Now either disable that plugin or enable it and optionally change some of the configuration parameters to a value different to the default.

Update to the patched package or custom update URL created by Drone for this PR.

Check if the "System - Session Data Purge" plugin has been uninstalled.

Check if there is a task scheduler plugin "Task - Session Data Purge".

Check enabled status and configuration parameters of that plugin.

Check if there is a scheduled task "SessionGC" using that plugin. If so, check the configuration parameters, too.

Repeat the previous steps with different endabled status and configuration parameters of the "System - Session Data Purge" plugin.

Actual result BEFORE applying this Pull Request

Deletion of outdated session data is done with the "System - Session Data Purge" plugin.

Expected result AFTER applying this Pull Request

New installation

The "Task - Session Data Purge" plugin is enabled, and a scheduled task "SessionGC" is enabled to run every 24 hours at the hour of the Joomla installation.

Update

The "System - Session Data Purge" plugin has been uninstalled by the update.

A new task scheduler plugin "Task - Session Data Purge" has been created and is enabled.

If the old "System - Session Data Purge" plugin was enabled before the update, a new scheduled task "SessionGC" has been created and is enabled.

It will execute every 24 hours at the hour of the Joomla installation.

The configuration parameters "Enable Session Data Cleanup", "Enable Session Metadata Cleanup", "Probability" and "Divisor" of that task are set to the same values as the same parameters in the old system plugin's parameters:

If the old "System - Session Data Purge" plugin was disabled before the update, there is no task for that plugin.

@heelc29 The PR is ready for testing. Code style error is not related to the PR but to the current 5.0-dev branch. Could you test again? Testing instructions can be found in the description of this PR. Thanks in advance.

The language strings for the backend, e.g. the plugin name, are not translated. The reason could be the casing of the Plugin PHP files, "SessionGC" instead of "Sessiongc".

I have tested this item ? unsuccessfully on cc22a2a

The language strings for the task in backend, e.g. the task type in the task list, or the parameter labels and descriptions in the form, are not translated. The reason could be the casing of the Plugin PHP files, "SessionGC" instead of "Sessiongc".

thanks richard for finishing this pr.

thank you all for your help