PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar roland-d
roland-d
6 Aug 2023

Summary of Changes

Add property currentUpdate so it is not dynamically created.

Testing Instructions

  1. Make sure you run PHP 8.2
  2. Go to the System => Joomla Update
  3. Notice the deprecation notice:
    Deprecated: Creation of dynamic property Joomla\CMS\Updater\Adapter\ExtensionAdapter::$currentUpdate is deprecated in /var/www/html/joomla5.test/libraries/src/Updater/Adapter/ExtensionAdapter.php on line 57
  4. Apply patch
  5. Refresh page
  6. Notice is gone

Actual result BEFORE applying this Pull Request

A notice is shown:

Deprecated: Creation of dynamic property Joomla\CMS\Updater\Adapter\ExtensionAdapter::$currentUpdate is deprecated in /var/www/html/joomla5.test/libraries/src/Updater/Adapter/ExtensionAdapter.php on line 57

Expected result AFTER applying this Pull Request

Notice is gone.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 6 Aug 2023
Category Libraries
avatar roland-d roland-d - open - 6 Aug 2023
avatar roland-d roland-d - change - 6 Aug 2023
Status New Pending
avatar alikon
alikon - comment - 6 Aug 2023

i've found some more on #41118

avatar roland-d
roland-d - comment - 6 Aug 2023

@alikon I searched but did not find your PR. Closing this in favor of #41118

avatar roland-d roland-d - close - 6 Aug 2023
avatar roland-d roland-d - change - 6 Aug 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-08-06 09:22:10
Closed_By roland-d
Labels Added: PR-5.0-dev
avatar alikon
alikon - comment - 6 Aug 2023

@roland-d would you like to help me with declarations docs ?

Add a Comment

Login with GitHub to post a comment