? ? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
2 Aug 2023

Pull Request for Issue #41291

Summary of Changes

return the description field

Testing Instructions

Do an API call and set the category description:

Actual result BEFORE applying this Pull Request

the description field is not returned

Expected result AFTER applying this Pull Request

the description field is present

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 2 Aug 2023
avatar alikon alikon - change - 2 Aug 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2023
Category Administration com_categories
avatar alikon alikon - change - 2 Aug 2023
Labels Added: PR-4.3-dev
avatar alikon alikon - change - 2 Aug 2023
Title
add description field
[4] webservice categories add description field
avatar alikon alikon - edited - 2 Aug 2023
avatar alikon alikon - change - 2 Aug 2023
The description was changed
avatar alikon alikon - edited - 2 Aug 2023
avatar Razzo1987 Razzo1987 - test_item - 3 Aug 2023 - Tested successfully
avatar Razzo1987
Razzo1987 - comment - 3 Aug 2023

I have tested this item successfully on 2970686

GET: content/categories
image

POST: content/categories
image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41307.
avatar Quy Quy - test_item - 3 Aug 2023 - Tested successfully
avatar Quy
Quy - comment - 3 Aug 2023

I have tested this item ✅ successfully on 2970686


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41307.

avatar Quy Quy - change - 3 Aug 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 3 Aug 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41307.

avatar laoneo
laoneo - comment - 3 Aug 2023

Can you rebase this to 4.4 and add a system test?

avatar obuisard obuisard - change - 3 Aug 2023
Labels Added: ? ?
avatar alikon
alikon - comment - 6 Aug 2023
avatar alikon
alikon - comment - 6 Aug 2023

wrong rebase i'll switch it back to 4.3

avatar obuisard obuisard - change - 13 Aug 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-13 13:41:25
Closed_By obuisard
avatar obuisard obuisard - close - 13 Aug 2023
avatar obuisard obuisard - merge - 13 Aug 2023
avatar obuisard
obuisard - comment - 13 Aug 2023

Thank you Nicola @alikon for the PR.

avatar laoneo
laoneo - comment - 13 Aug 2023

rebased to 4.4 aren't system test already there https://github.com/joomla/joomla-cms/blame/4.3-dev/tests/Codeception/api/com_content/ContentCest.php#L97 ?

In 4.4 we do the system tests on cypress here.

avatar obuisard
obuisard - comment - 13 Aug 2023

I am reverting, will re-create it for 4.4. I apologize @alikon, I will link the new PR to this one.

Add a Comment

Login with GitHub to post a comment