[#41300] - [5.2] Fix Joomla.renderMessages not found with mod_login
- Fixed in Code Base
- 16 Nov 2024
- Medium
- Build: 4.3-dev
- # 41300
- Diff
- Fedik:fix-41299
User tests: Successful: Unsuccessful:
Pull Request for Issue #41299 .
Summary of Changes
Add missing dependency for Joomla.renderMessages
Testing Instructions
Please follow #41299
Actual result BEFORE applying this Pull Request
JS error
Expected result AFTER applying this Pull Request
No error
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
Same with frontend login - no problems.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41300.
This pull request has been automatically rebased to 4.4-dev.
Quy
- 
I have tested this item ? unsuccessfully on e67eb16
Could not reproduce the Javascript error in the console on failed login. My method:
Create user with a valid webauthn setup.
Check that login works for this user on the front-end using the mod_login form.
Log the user out in front-end.
Remove the webauthn setup for this user.
Reload page.
Try to login again as webauth for this user.
No Javascript errors in console. Only an formatted error message is displayed: "The credential ID is invalid." So It is rendering the message just fine.
Joomla 4.4.3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41300.
| Title |
|
||||||
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
| Labels |
Added:
PBF
bug
Maintainers Checked
Small
PR-4.4-dev
PR-5.2-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-11-16 16:13:44 |
| Closed_By | ⇒ | wilsonge |
Merging on review. Whilst messages is on many pages - it's clearly a dependency of the script
I can't reproduce this problem. I have
Multi-factor Authentication is not enabled.I have registered my Authenticator inW3C Web Authentication (WebAuthn) Login. In the Admin login form I click the button on the dongle when prompted and login works normally. With a user not using that method there is a normal error message. Everything I see is translated. I do not see any Javascript error messages.Perhaps some more specific test instructions would help. I am using joomla-cms with 4.3-dev checked out and Chrome/Firefox on Mac.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41300.