? NPM Resource Changed PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
30 Jul 2023

Pull Request for Issues #41284 and #41283 .

Summary of Changes

Dark mode changes by upstream bootstrap caused a few theme variant colors to not be propogated into the template

twbs/bootstrap@fc3f4b6#diff-be56ca5fb07a1b48548ec8b7ec33a30c15c2f9263a3bcc1c664ade171f7ba264

This also fixes a few other missing bootstrap variables (I'm not sure all of them are due to the template upgrade - but better safe than sorry :) )

Testing Instructions

Check views explicitly mentioned in the two issues and also have a general browse around the rest of the admin to ensure nothing else is affected by the theme level view change

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 30 Jul 2023
Category Repository NPM Change
avatar wilsonge wilsonge - open - 30 Jul 2023
avatar wilsonge wilsonge - change - 30 Jul 2023
Status New Pending
avatar wilsonge wilsonge - change - 30 Jul 2023
Labels Added: NPM Resource Changed PR-4.4-dev
avatar heelc29 heelc29 - test_item - 31 Jul 2023 - Tested successfully
avatar heelc29
heelc29 - comment - 31 Jul 2023

I have tested this item successfully on fd5ccc7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41286.

avatar wilsonge wilsonge - change - 31 Jul 2023
Title
Fix/list group
[4.4] Fix minor UI issues caused by bootstrap 5.3 version bump
avatar wilsonge wilsonge - edited - 31 Jul 2023
avatar Quy Quy - test_item - 31 Jul 2023 - Tested successfully
avatar Quy
Quy - comment - 31 Jul 2023

I have tested this item successfully on fd5ccc7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41286.

avatar Quy Quy - change - 31 Jul 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 31 Jul 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41286.

avatar HLeithner HLeithner - close - 1 Aug 2023
avatar HLeithner HLeithner - merge - 1 Aug 2023
avatar HLeithner HLeithner - change - 1 Aug 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-01 09:34:07
Closed_By HLeithner
Labels Added: ?
avatar HLeithner
HLeithner - comment - 1 Aug 2023

Thc

Add a Comment

Login with GitHub to post a comment