Language Change NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
29 Jul 2023

This allows system plugins using the JPlugin class to still work with joomla 5.0 compatibility enabled

Pull Request for Issue when system plugins need JPlugin before the b/c plugin is loaded

Summary of Changes

Moved the plugin from the system folder to the behaviour folder which is the first folder loaded by the cms.

Testing Instructions

Use a system plugin which extends JPlugin.

Actual result BEFORE applying this Pull Request

Might not work

Expected result AFTER applying this Pull Request

Works now.

avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2023
Category SQL Administration com_admin Postgresql Language & Strings Repository NPM Change Installation Front End Plugins
avatar HLeithner HLeithner - open - 29 Jul 2023
avatar HLeithner HLeithner - change - 29 Jul 2023
Status New Pending
avatar HLeithner HLeithner - change - 29 Jul 2023
Labels Added: Language Change NPM Resource Changed PR-5.0-dev
avatar brianteeman
brianteeman - comment - 29 Jul 2023

Please add scripts to remove the system plugin files
Please add sql to remove the system plugin
Please update the language strings to use the correct prefix

avatar HLeithner
HLeithner - comment - 29 Jul 2023

not planing to do so, within alpha, only starting with beta1 to include an upgrade path

avatar brianteeman
brianteeman - comment - 29 Jul 2023

This is wrong - makes the nightly builds pointless

avatar HLeithner
HLeithner - comment - 29 Jul 2023

not true, they are for new installations and update from last stable version.

avatar brianteeman
brianteeman - comment - 29 Jul 2023

not true but you clearly know best and are free to change the practices of the last few years. Perhaps you could point me to the place on the downbload page for nightly builds where it states that. From my reading of that document there is no mention of your assertion.

avatar HLeithner
HLeithner - comment - 29 Jul 2023

Warning! These builds are intended for testing purposes only and should never be used on production websites.

We can break joomla installations beyond repair and in alpha version till beta1 of joomla 4 no upgrade policy exists. before this point in time even update breaks between rc and final exists (can't remember if this happend or not).

any way alpha is for testing and not for wasting time to write update scripts for 10 users that might need them because they don't have backups.

avatar bayareajenn bayareajenn - test_item - 1 Aug 2023 - Tested successfully
avatar bayareajenn
bayareajenn - comment - 1 Aug 2023

I have tested this item successfully on 71c7f5f

This resolved the issue for extensions with class JPlugin not working with the b/c plugin enabled. Tested two extensions that previously wouldn't install with b/c plugin enabled without throwing the JPlugin error. They install with this PR. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41276.

avatar HLeithner HLeithner - change - 1 Aug 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-01 18:54:58
Closed_By HLeithner
avatar HLeithner HLeithner - close - 1 Aug 2023
avatar HLeithner HLeithner - merge - 1 Aug 2023
avatar HLeithner
HLeithner - comment - 1 Aug 2023

thanks for testing

Add a Comment

Login with GitHub to post a comment