Joomla! Issue Tracker | Joomla! CMS #41271 - [5.0] schemaorg format json-ld

? PR-5.0-dev

Fixed in Code Base
13 Aug 2023
Medium
Build: 5.0-dev
# 41271
Diff
heelc29:5.0/schemaorg/json-kd

Pending

User tests: Successful: Unsuccessful:

heelc29
27 Jul 2023

Summary of Changes

use same json flags for breadcrumbs like the schemaorg plugin (see also #41250)

joomla-cms/modules/mod_breadcrumbs/tmpl/default.php

Line 120 in a8e363d

$wa->addInline('script', json_encode($data, JSON_UNESCAPED_UNICODE), [], ['type' => 'application/ld+json']);

joomla-cms/plugins/system/schemaorg/src/Extension/Schemaorg.php

Line 457 in a8e363d

$schemaString = $schema->toString('JSON', ['bitmask' => JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE]);

pretty print json like MetasRenderer

joomla-cms/libraries/src/Document/Renderer/Html/MetasRenderer.php

Lines 71 to 72 in a8e363d

    
           $prettyPrint = (JDEBUG && \defined('JSON_PRETTY_PRINT') ? JSON_PRETTY_PRINT : false); 
        
           $jsonOptions = json_encode($scriptOptions, $prettyPrint);

Testing Instructions

check schemaorg ouput for breadcrumbs
enable debug mode

Actual result BEFORE applying this Pull Request

{"@context":"https:\/\/schema.org","@type":"BreadcrumbList","@id":"https:\/\/j50dev.localhost\/#\/schema\/BreadcrumbList\/17"

{"@context":"https://schema.org","@graph":[{"@type":"Person","@id":"https://j50dev.localhost/#/schema/Person/base","url":"https://j50dev.localhost/"}

Expected result AFTER applying this Pull Request

{"@context":"https://schema.org","@type":"BreadcrumbList","@id":"https://j50dev.localhost/#/schema/BreadcrumbList/17"

{
    "@context": "https://schema.org",
    "@graph": [
        {
            "@type": "Person",
            "@id": "https://j50dev.localhost/#/schema/Person/base",
            "url": "https://j50dev.localhost/"
        }

Link to documentations

Please select:

No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed

f988a5b 27 Jul 2023

[5.0] schemaorg format json-ld

30d01bc 27 Jul 2023

[5.0] schemaorg format json-ld

joomla-cms-bot - change - 27 Jul 2023

Category

⇒

Modules Front End Plugins

heelc29 - open - 27 Jul 2023

heelc29 - change - 27 Jul 2023

Status

New

⇒

Pending

brianteeman - comment - 27 Jul 2023

wtf. so it is never possible to have the old style breadcrumbs itemprop richdata because this is hardcoded in the tmpl even though all richdata has been removed from tmpl files everywhere else.

:banginghead:

heelc29 - comment - 27 Jul 2023

I don't know ... I only see its linked ?

joomla-cms/plugins/system/schemaorg/src/Extension/Schemaorg.php

Lines 410 to 415 in a8e363d

    
           // We support Breadcrumb linking 
        
           $breadcrumbs = ModuleHelper::getModule('mod_breadcrumbs'); 
        
           if (!empty($breadcrumbs->id)) { 
        
               $webPageSchema['breadcrumb'] = ['@id' => $domain . '#/schema/BreadcrumbList/' . (int) $breadcrumbs->id]; 
        
           }

6176657 7 Aug 2023

Merge branch '5.0-dev' into 5.0/schemaorg/json-kd

e63e707 7 Aug 2023

update

heelc29 - change - 7 Aug 2023

Labels

Added: PR-5.0-dev

Fedik - test_item - 7 Aug 2023 - Tested successfully

Fedik - comment - 7 Aug 2023

I have tested this item ✅ successfully on e63e707

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41271.}

f61b122 7 Aug 2023

Merge branch '5.0-dev' into 5.0/schemaorg/json-kd

Quy - test_item - 11 Aug 2023 - Tested successfully

Quy - alter_testresult - 11 Aug 2023 - Fedik: Tested successfully

Quy - comment - 11 Aug 2023

I have tested this item ✅ successfully on f61b122

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41271.}

Quy - change - 11 Aug 2023

Status

Pending

⇒

Ready to Commit

Quy - comment - 11 Aug 2023

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41271.}

313e177 11 Aug 2023

Merge branch '5.0-dev' into 5.0/schemaorg/json-kd

Quy - change - 11 Aug 2023

Labels

Added: ?

HLeithner - change - 13 Aug 2023

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2023-08-13 17:31:40
Closed_By		⇒	HLeithner

HLeithner - close - 13 Aug 2023

HLeithner - merge - 13 Aug 2023

HLeithner - comment - 13 Aug 2023

thanks

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#41271] - [5.0] schemaorg format json-ld

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Add a Comment

	$prettyPrint = (JDEBUG && \defined('JSON_PRETTY_PRINT') ? JSON_PRETTY_PRINT : false);
	$jsonOptions = json_encode($scriptOptions, $prettyPrint);

	// We support Breadcrumb linking
	$breadcrumbs = ModuleHelper::getModule('mod_breadcrumbs');

	if (!empty($breadcrumbs->id)) {
	$webPageSchema['breadcrumb'] = ['@id' => $domain . '#/schema/BreadcrumbList/' . (int) $breadcrumbs->id];
	}