[#41265] - [5.0] schemaorg Deprecated: Function strftime()
- Closed
- 26 Aug 2023
- Medium
- Build: 4.3-dev
- # 41265
Steps to reproduce the issue
with the Blogposting schema use the date picker to add a date for published and modified date
Expected result
date selected
Actual result
Deprecated: Function strftime() is deprecated in libraries\src\Form\Field\CalendarField.php on line 322
System information (as much as possible)
php 8.1.10
Additional comments
also tested with #41260 but no change
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
richard67
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-07-27 14:25:02 |
| Closed_By | ⇒ | richard67 |
Please re-open - that PR doesnt work
| Status | Closed | ⇒ | New |
| Closed_Date | 2023-07-27 14:25:02 | ⇒ | |
| Closed_By | richard67 | ⇒ |
I don't understand how this feature works yet. However, to prevent this deprecated warnings, we should add missing filterformat="Y-m-d" after this line https://github.com/joomla/joomla-cms/blob/5.0-dev/plugins/schemaorg/blogposting/forms/schemaorg.xml#L156
We should search for all calendar fields under plugins/schemaorg folder and add the missing filterformat definition.
Wouldn't it be better to just fix it here: https://github.com/joomla/joomla-cms/blob/4.3-dev/libraries/src/Form/Field/CalendarField.php#L322C36-L322C36 ?
| Labels |
Added:
bug
|
||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-26 09:27:52 |
| Closed_By | ⇒ | joomdonation |
Wouldn't it be better to just fix it here: https://github.com/joomla/joomla-cms/blob/4.3-dev/libraries/src/Form/Field/CalendarField.php#L322C36-L322C36 ?
Unfortunately, there is no reliable solution, see #41266 for an example attempt. The easiest solution would be adding translateformat="true" to these fields, I made PR #41453 for that. Please test, thanks !
It looks like we created a request at the same time, you created an ISSUE, I created a PR. I haven't seen your ISSUE.?