PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
26 Jul 2023

Summary of Changes

  • Moved cleanup functions to individual traits
  • Added traits to each plugin
  • Improved blog/categories views
  • Added global cleanup to schemaorg system plugin

Testing Instructions

  • Create different articles with schema information
  • Check head area of your page

Actual result BEFORE applying this Pull Request

  • empty values
  • wrong format for date/image/durations

Expected result AFTER applying this Pull Request

  • No empty values
  • Correct image/date/duration compilation

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 26 Jul 2023
Category Libraries Front End Plugins
avatar bembelimen bembelimen - open - 26 Jul 2023
avatar bembelimen bembelimen - change - 26 Jul 2023
Status New Pending
avatar brianteeman
brianteeman - comment - 27 Jul 2023

I am getting this in the frontendand admin for all the schema
example

Deprecated
: Calling static trait method Joomla\CMS\Schemaorg\SchemaorgPluginTrait::getSubscribedEvents is deprecated, it should only be called on a class using the trait in plugins\schemaorg\blogposting\src\Extension\Blogposting.php
on line
61

Php 8.1.10

avatar bembelimen bembelimen - change - 27 Jul 2023
Labels Added: PR-5.0-dev
avatar bembelimen
bembelimen - comment - 27 Jul 2023

I am getting this in the frontendand admin for all the schema example

Deprecated
: Calling static trait method Joomla\CMS\Schemaorg\SchemaorgPluginTrait::getSubscribedEvents is deprecated, it should only be called on a class using the trait in plugins\schemaorg\blogposting\src\Extension\Blogposting.php
on line
61

Php 8.1.10

Thx,
tried here something which did not work anymore. Fixed it now.

avatar laoneo
laoneo - comment - 28 Jul 2023

What is the benefit of having here traits and not a proper base class as we have for actionlog, fields, etc.?

avatar HLeithner
HLeithner - comment - 28 Jul 2023

What is the benefit of having here traits and not a proper base class as we have for actionlog, fields, etc.?

you only take the traits you need.

avatar Fedik Fedik - test_item - 5 Aug 2023 - Tested successfully
avatar Fedik
Fedik - comment - 5 Aug 2023

I have tested this item ✅ successfully on 7d87e4d

It is working from what I can see :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41260.

avatar HLeithner HLeithner - change - 5 Aug 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-05 16:30:24
Closed_By HLeithner
avatar HLeithner HLeithner - close - 5 Aug 2023
avatar HLeithner HLeithner - merge - 5 Aug 2023
avatar HLeithner
HLeithner - comment - 5 Aug 2023

Thanks

Add a Comment

Login with GitHub to post a comment